From patchwork Wed Apr 23 09:04:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nylon Chen X-Patchwork-Id: 2076028 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=google header.b=l/BFXzFY; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=147.75.80.249; helo=am.mirrors.kernel.org; envelope-from=linux-pwm+bounces-5667-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org [147.75.80.249]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4ZjCbR3KmCz1yMm for ; Wed, 23 Apr 2025 18:54:43 +1000 (AEST) Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 880441B61EF5 for ; Wed, 23 Apr 2025 08:55:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3552F223DCB; Wed, 23 Apr 2025 08:53:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="l/BFXzFY" X-Original-To: linux-pwm@vger.kernel.org Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A3F21FF4F for ; Wed, 23 Apr 2025 08:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398416; cv=none; b=ZUBojXKTAVrRX7mVEE7AeeFuFdu31DSlBKPTcsQSWic6d6XfG1fLIOB7F6mDoN7p1bWDNvsL2Byg5lEjqVJFnXSR6ZTl8PbFkanHVmMQOisc2RbbfefG00yRItV/DG9OXYyzaI6VusJoZroLwJ6yTRmNg6/GLnv6/T7Eumj5WSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745398416; c=relaxed/simple; bh=3r/5Z/FYNGrd9yVol3oPvJOMUrAGXQMWCQuwPGjhyIU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ufjH0vfDvRrYFXLLUWsK9/lT/nWVzg77+PZzCJQUwm0KKkq8tnX/TrF/jSH5N3UNZ57gv0XcsKZJ9BkmhdLxlFzlpD4/cgW6W5JOfgkrPOUFpgQbSlOKwHvuUN9IL7TwILRladHo6Jfy1DceOB+apmJde4asAG0CNELAFZH3yZo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com; spf=pass smtp.mailfrom=sifive.com; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b=l/BFXzFY; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-301c4850194so4633520a91.2 for ; Wed, 23 Apr 2025 01:53:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1745398413; x=1746003213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0ySeC6yawUczfsda0tPZSNQIrOLUHwdCmyF43sMLfrQ=; b=l/BFXzFYywi7/G3t8cBtRni0/CZA3hGD2bySF7QiOGUGb8+zYoKc8/stk3r9riNFnw /LNkxvkRxvALiGOkjeBJouN8eKjJaa3XXhgBLNaKENBZbwKMaLvfj46B8WiPJdDCNpsz gzgccTtbDOEluw5csuUwAy1CZWdwinYbcX+u4fvOB3vstMYyHKuUMwUvFk+Ph9qg03W8 mhsPHSpA1Rwb5biWDsz0dbBSr/ITkkzI8yTlb2l8Gb17m+tHEu/5IEPc1mdS4+yIlemU CvV7qEUV9kD3CXBBNMNSEsZrJ6alWM+vdTlb8LVgQReLU0E7etLhgSypQNXkVQg3NPix wg9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745398413; x=1746003213; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ySeC6yawUczfsda0tPZSNQIrOLUHwdCmyF43sMLfrQ=; b=b/twWGsrKOaZLFQuPLDQDuH2GyPRn5/1wzfgg2kRn4jYURZxAcoeRgH0+3sO9zKk1P BtfojPsdjiz97FoKWUwgIFEH1p6s1K9TeAITr34BOkV3rSXiN+M5b9mLPw2tmEFBJ33k uXdH9xvZL/Y5qCm7xmHkwkC5aOxTVVkc5j18iF/oQ6Gc456QGX/3Oz4JfK3wY+2HUSBC hvKc1jUVb36+OZXEjVY8zhvYaUBPDCOqRsI1huxG9kNdfcenyLiXUaOLE/oOZeVTgn+y H33Pc1le2QK1zfcZuyoaij52xgrFoRzBVgBE3eYhyQawtkstNkJlfuTyn70NEP/LLLnB QsJw== X-Forwarded-Encrypted: i=1; AJvYcCUMRBCsKzHDWhbD2lMCxAqCxCJHlbMqeJtbGx+KBYIrjpYaV7l0MzUeoCys6nOxj6DPpVSUKv9YW5Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8NnX/LjkDF/Wd5SK6AcgT7V7qFuOyB/0lt6iKGPPr+BPoS69I zKwwQ7cP+kie0KCboMOIAUqWyN5z01D/uU4vjEZtE2Y8LerTuw9DNUPu3jgSy08= X-Gm-Gg: ASbGncsCtyxoCOjFFQv1cKEQHYMRlQI9rsjDoZMi3qQAMi22yB67PhE5F/yVfOxRbMe zsD6/UUP6LoStcY8Y9l6Ahb9jtKymJ6L0/+GOi2i1uVve6OgtZ8I5cXmZiOcxQxZm+Ps4fQTtgv eDtMg+Aw7vwI4czLiaFOSI45CrkJXAZYh+E9qZNHZwBQHRcV+NOsQYFXxLWuZJ29X0xEnFsahbX EqMczzijGkBksovYOPGpRxQCjXe0at2wUeFFZBElFMbso0JBpfVuahMMdEq2Do21Xaf9tylvQmd El6LepWYz6x2doJwOKs0sHM2/NNWIKVkmelrL8eglnciEvoEoQ+wvOy5UPwzCun0HV6FZyJeieH STA== X-Google-Smtp-Source: AGHT+IGCdyRrXA3gFk3nBMhtBGH9c8nvuEZ3lZ6EALzxbQyXUOgptExJPWtu72AQ/7Ux8Uo93heJog== X-Received: by 2002:a17:90b:380b:b0:2f6:d266:f45e with SMTP id 98e67ed59e1d1-3087bb3e794mr27325433a91.2.1745398412701; Wed, 23 Apr 2025 01:53:32 -0700 (PDT) Received: from hsinchu36-syssw02.internal.sifive.com ([210.176.154.34]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-309dfa5f880sm1047611a91.38.2025.04.23.01.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Apr 2025 01:53:32 -0700 (PDT) From: Nylon Chen To: Conor Dooley , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= Cc: linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, Nylon Chen , Zong Li Subject: [PATCH v13 4/5] pwm: sifive: Fix rounding issues in apply and get_state functions Date: Wed, 23 Apr 2025 17:04:45 +0800 Message-Id: <20250423090446.294846-5-nylon.chen@sifive.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250423090446.294846-1-nylon.chen@sifive.com> References: <20250423090446.294846-1-nylon.chen@sifive.com> Precedence: bulk X-Mailing-List: linux-pwm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Fix PWM apply and get_state rounding to ensure consistency between setting and reading values This fixes the reported errors: pwm-sifive 10021000.pwm: .apply is supposed to round down duty_cycle (requested: 360/504000, applied: 361/504124) pwm-sifive 10021000.pwm: .apply is supposed to round down period (requested: 504000, applied: 504124) Co-developed-by: Zong Li Signed-off-by: Zong Li Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 6259f8500f71..4cf3e715fd84 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -122,8 +122,8 @@ static int pwm_sifive_get_state(struct pwm_chip *chip, struct pwm_device *pwm, state->enabled = false; state->period = ddata->real_period; - state->duty_cycle = - (u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH; + state->duty_cycle = DIV_ROUND_UP_ULL((u64)duty * ddata->real_period, + (1U << PWM_SIFIVE_CMPWIDTH)); state->polarity = PWM_POLARITY_NORMAL; return 0; @@ -157,7 +157,8 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm, * consecutively */ num = (u64)duty_cycle * (1U << PWM_SIFIVE_CMPWIDTH); - frac = DIV64_U64_ROUND_CLOSEST(num, state->period); + frac = num; + do_div(frac, state->period); /* The hardware cannot generate a 0% duty cycle */ frac = min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); inactive = (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac;