| Message ID | 20231106095205.231210-4-alexander.stein@ew.tq-group.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | imx8qm/imx8qxp: Support for inverted PWM | expand |
Hello, [Cc -= Philippe Schenker] On Mon, Nov 06, 2023 at 10:52:05AM +0100, Alexander Stein wrote: > i.MX8QXP supports inverted PWM output, thus #pwm-cells needs to be set > to 3. > > Fixes: f1d6a6b991ef9 ("arm64: dts: imx8qxp: add adma_pwm in adma") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > index ce66d30a4839b..b0bb77150adcc 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi > @@ -149,7 +149,7 @@ adma_pwm: pwm@5a190000 { > clock-names = "ipg", "per"; > assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>; > assigned-clock-rates = <24000000>; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>; > }; Even without patch #1 this is a good change. There are no usages of the adma_pwm handle as of today's next. So no consumers need adaption. Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi index ce66d30a4839b..b0bb77150adcc 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi @@ -149,7 +149,7 @@ adma_pwm: pwm@5a190000 { clock-names = "ipg", "per"; assigned-clocks = <&clk IMX_SC_R_LCD_0_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; power-domains = <&pd IMX_SC_R_LCD_0_PWM_0>; };
i.MX8QXP supports inverted PWM output, thus #pwm-cells needs to be set to 3. Fixes: f1d6a6b991ef9 ("arm64: dts: imx8qxp: add adma_pwm in adma") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- arch/arm64/boot/dts/freescale/imx8-ss-dma.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)