| Message ID | 20231106095205.231210-3-alexander.stein@ew.tq-group.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | imx8qm/imx8qxp: Support for inverted PWM | expand |
Hello, [again Cc -= Philippe Schenker] On Mon, Nov 06, 2023 at 10:52:04AM +0100, Alexander Stein wrote: > i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set > to 3. > > Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3") > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi > index 49ad3413db948..7e510b21bbac5 100644 > --- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi > @@ -29,7 +29,7 @@ lsio_pwm0: pwm@5d000000 { > <&pwm0_lpcg 1>; > assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; > assigned-clock-rates = <24000000>; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > @@ -42,7 +42,7 @@ lsio_pwm1: pwm@5d010000 { > <&pwm1_lpcg 1>; > assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>; > assigned-clock-rates = <24000000>; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > @@ -55,7 +55,7 @@ lsio_pwm2: pwm@5d020000 { > <&pwm2_lpcg 1>; > assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>; > assigned-clock-rates = <24000000>; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; > @@ -68,7 +68,7 @@ lsio_pwm3: pwm@5d030000 { > <&pwm3_lpcg 1>; > assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>; > assigned-clock-rates = <24000000>; > - #pwm-cells = <2>; > + #pwm-cells = <3>; > interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; > status = "disabled"; > }; Even without patch #1 this is a good change. There are no usages of the lsio_pwm* handles as of today's next. So no consumers need adaption. Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi index 49ad3413db948..7e510b21bbac5 100644 --- a/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi @@ -29,7 +29,7 @@ lsio_pwm0: pwm@5d000000 { <&pwm0_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_0 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; @@ -42,7 +42,7 @@ lsio_pwm1: pwm@5d010000 { <&pwm1_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_1 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; @@ -55,7 +55,7 @@ lsio_pwm2: pwm@5d020000 { <&pwm2_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_2 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; }; @@ -68,7 +68,7 @@ lsio_pwm3: pwm@5d030000 { <&pwm3_lpcg 1>; assigned-clocks = <&clk IMX_SC_R_PWM_3 IMX_SC_PM_CLK_PER>; assigned-clock-rates = <24000000>; - #pwm-cells = <2>; + #pwm-cells = <3>; interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; status = "disabled"; };
i.MX8QM/QXP supports inverted PWM output, thus #pwm-cells needs to be set to 3. Fixes: a05c329644d81 ("arm64: dts: freescale: imx8-ss-lsio: add support for lsio_pwm0-3") Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- arch/arm64/boot/dts/freescale/imx8-ss-lsio.dtsi | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)