@@ -16,7 +16,6 @@
struct gb_pwm_chip {
struct gb_connection *connection;
- u8 pwm_max; /* max pwm number */
struct pwm_chip chip;
};
@@ -26,19 +25,6 @@ static inline struct gb_pwm_chip *pwm_chip_to_gb_pwm_chip(struct pwm_chip *chip)
return container_of(chip, struct gb_pwm_chip, chip);
}
-static int gb_pwm_count_operation(struct gb_pwm_chip *pwmc)
-{
- struct gb_pwm_count_response response;
- int ret;
-
- ret = gb_operation_sync(pwmc->connection, GB_PWM_TYPE_PWM_COUNT,
- NULL, 0, &response, sizeof(response));
- if (ret)
- return ret;
- pwmc->pwm_max = response.count;
- return 0;
-}
-
static int gb_pwm_activate_operation(struct gb_pwm_chip *pwmc,
u8 which)
{
@@ -46,9 +32,6 @@ static int gb_pwm_activate_operation(struct gb_pwm_chip *pwmc,
struct gbphy_device *gbphy_dev;
int ret;
- if (which > pwmc->pwm_max)
- return -EINVAL;
-
request.which = which;
gbphy_dev = to_gbphy_dev(pwmc->chip.dev);
@@ -71,9 +54,6 @@ static int gb_pwm_deactivate_operation(struct gb_pwm_chip *pwmc,
struct gbphy_device *gbphy_dev;
int ret;
- if (which > pwmc->pwm_max)
- return -EINVAL;
-
request.which = which;
gbphy_dev = to_gbphy_dev(pwmc->chip.dev);
@@ -96,9 +76,6 @@ static int gb_pwm_config_operation(struct gb_pwm_chip *pwmc,
struct gbphy_device *gbphy_dev;
int ret;
- if (which > pwmc->pwm_max)
- return -EINVAL;
-
request.which = which;
request.duty = cpu_to_le32(duty);
request.period = cpu_to_le32(period);
@@ -123,9 +100,6 @@ static int gb_pwm_set_polarity_operation(struct gb_pwm_chip *pwmc,
struct gbphy_device *gbphy_dev;
int ret;
- if (which > pwmc->pwm_max)
- return -EINVAL;
-
request.which = which;
request.polarity = polarity;
@@ -149,9 +123,6 @@ static int gb_pwm_enable_operation(struct gb_pwm_chip *pwmc,
struct gbphy_device *gbphy_dev;
int ret;
- if (which > pwmc->pwm_max)
- return -EINVAL;
-
request.which = which;
gbphy_dev = to_gbphy_dev(pwmc->chip.dev);
@@ -174,9 +145,6 @@ static int gb_pwm_disable_operation(struct gb_pwm_chip *pwmc,
struct gbphy_device *gbphy_dev;
int ret;
- if (which > pwmc->pwm_max)
- return -EINVAL;
-
request.which = which;
ret = gb_operation_sync(pwmc->connection, GB_PWM_TYPE_DISABLE,
@@ -266,20 +234,28 @@ static int gb_pwm_probe(struct gbphy_device *gbphy_dev,
struct gb_connection *connection;
struct gb_pwm_chip *pwmc;
struct pwm_chip *chip;
+ struct gb_pwm_count_response response;
int ret;
- pwmc = kzalloc(sizeof(*pwmc), GFP_KERNEL);
- if (!pwmc)
- return -ENOMEM;
-
connection = gb_connection_create(gbphy_dev->bundle,
le16_to_cpu(gbphy_dev->cport_desc->id),
NULL);
- if (IS_ERR(connection)) {
- ret = PTR_ERR(connection);
- goto exit_pwmc_free;
+ if (IS_ERR(connection))
+ return PTR_ERR(connection);
+
+ ret = gb_operation_sync(pwmc->connection, GB_PWM_TYPE_PWM_COUNT,
+ NULL, 0, &response, sizeof(response));
+ if (ret)
+ goto exit_connection_destroy;
+
+ chip = devm_pwmchip_alloc(&gbphy_dev->dev, response.count, sizeof(*pwmc));
+ if (IS_ERR(chip)) {
+ ret = PTR_ERR(chip);
+ goto exit_connection_destroy;
}
+ pwmc = pwmchip_priv(chip);
+
pwmc->connection = connection;
gb_connection_set_data(connection, pwmc);
gb_gbphy_set_data(gbphy_dev, pwmc);
@@ -288,16 +264,9 @@ static int gb_pwm_probe(struct gbphy_device *gbphy_dev,
if (ret)
goto exit_connection_destroy;
- /* Query number of pwms present */
- ret = gb_pwm_count_operation(pwmc);
- if (ret)
- goto exit_connection_disable;
-
chip = &pwmc->chip;
- chip->dev = &gbphy_dev->dev;
chip->ops = &gb_pwm_ops;
- chip->npwm = pwmc->pwm_max + 1;
ret = pwmchip_add(chip);
if (ret) {
@@ -313,8 +282,6 @@ static int gb_pwm_probe(struct gbphy_device *gbphy_dev,
gb_connection_disable(connection);
exit_connection_destroy:
gb_connection_destroy(connection);
-exit_pwmc_free:
- kfree(pwmc);
return ret;
}
This prepares the greybus pwm driver to further changes of the pwm core outlined in the commit introducing devm_pwmchip_alloc(). There is no intended semantical change and the driver should behave as before. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/staging/greybus/pwm.c | 63 +++++++++-------------------------- 1 file changed, 15 insertions(+), 48 deletions(-)