diff mbox series

pwm: Drop unused #include <linux/radix-tree.h>

Message ID 20230728071259.590902-1-u.kleine-koenig@pengutronix.de
State Accepted
Headers show
Series pwm: Drop unused #include <linux/radix-tree.h> | expand

Commit Message

Uwe Kleine-König July 28, 2023, 7:12 a.m. UTC
core.c doens't use any of the symbols provided by linux/radix-tree.h
and compiles just fine without this include. So drop the #include.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/core.c | 1 -
 1 file changed, 1 deletion(-)


base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5

Comments

Thierry Reding July 28, 2023, 7:30 a.m. UTC | #1
On Fri, Jul 28, 2023 at 09:12:59AM +0200, Uwe Kleine-König wrote:
> core.c doens't use any of the symbols provided by linux/radix-tree.h
> and compiles just fine without this include. So drop the #include.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/pwm/core.c | 1 -
>  1 file changed, 1 deletion(-)

Looks like I forgot to remove that when the radix tree support was
dropped in 247ee6c780406513c6031a7f4ea41f1648b03295. This didn't apply
cleanly, so it breaks the b4 tracking.

Applied, thanks.

Thierry

> 
> diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> index 3dacceaef4a9..5b0794858ad4 100644
> --- a/drivers/pwm/core.c
> +++ b/drivers/pwm/core.c
> @@ -9,7 +9,6 @@
>  #include <linux/acpi.h>
>  #include <linux/module.h>
>  #include <linux/pwm.h>
> -#include <linux/radix-tree.h>
>  #include <linux/list.h>
>  #include <linux/mutex.h>
>  #include <linux/err.h>
> 
> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
> -- 
> 2.39.2
>
Uwe Kleine-König July 28, 2023, 7:59 a.m. UTC | #2
On Fri, Jul 28, 2023 at 09:30:13AM +0200, Thierry Reding wrote:
> On Fri, Jul 28, 2023 at 09:12:59AM +0200, Uwe Kleine-König wrote:
> > core.c doens't use any of the symbols provided by linux/radix-tree.h
> > and compiles just fine without this include. So drop the #include.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> >  drivers/pwm/core.c | 1 -
> >  1 file changed, 1 deletion(-)
> 
> Looks like I forgot to remove that when the radix tree support was
> dropped in 247ee6c780406513c6031a7f4ea41f1648b03295. This didn't apply
> cleanly, so it breaks the b4 tracking.

Ah right, I based it on v6.5-rc1 while it conflicts with commit
0a41b0c5d97a ("pwm: Explicitly include correct DT includes"). If you
pass -3 to git am, it applies fine though.

I don't know what you mean by "b4 tracking", maybe git am -3 fixes that,
too?

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 3dacceaef4a9..5b0794858ad4 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -9,7 +9,6 @@ 
 #include <linux/acpi.h>
 #include <linux/module.h>
 #include <linux/pwm.h>
-#include <linux/radix-tree.h>
 #include <linux/list.h>
 #include <linux/mutex.h>
 #include <linux/err.h>