diff mbox series

[v2,3/4] pwm: Mark free pwm IDs as used in alloc_pwms()

Message ID 20221117211143.3817381-4-u.kleine-koenig@pengutronix.de
State Accepted
Headers show
Series pwm: Some refactoring of pwmchip_add() | expand

Commit Message

Uwe Kleine-König Nov. 17, 2022, 9:11 p.m. UTC
alloc_pwms() only identified a free range of IDs and this range was marked
as used only later by pwmchip_add(). Instead let alloc_pwms() already do
the marking (which makes the function actually allocating the range and so
justifies the function name). This way access to the allocated_pwms
bitfield is limited to two functions only.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/pwm/core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series


diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 2338119a09d8..b43b24bd3c9f 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -51,6 +51,8 @@  static int alloc_pwms(unsigned int count)
 	if (start + count > MAX_PWMS)
 		return -ENOSPC;
+	bitmap_set(allocated_pwms, start, count);
 	return start;
@@ -297,8 +299,6 @@  int pwmchip_add(struct pwm_chip *chip)
 		radix_tree_insert(&pwm_tree, pwm->pwm, pwm);
-	bitmap_set(allocated_pwms, chip->base, chip->npwm);
 	list_add(&chip->list, &pwm_chips);