| Message ID | 20210412200155.5316-2-jbx6244@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/4] dt-bindings: pwm: convert pwm-rockchip.txt to YAML | expand |
On Mon, 12 Apr 2021 22:01:53 +0200, Johan Jonker wrote: > The compatible strings below are already in use in the Rockchip > dtsi files, but were somehow never added to a document, so add > > "rockchip,rk3328-pwm" > > "rockchip,rk3036-pwm", "rockchip,rk2928-pwm" > > "rockchip,rk3368-pwm", "rockchip,rk3288-pwm" > "rockchip,rk3399-pwm", "rockchip,rk3288-pwm" > > "rockchip,px30-pwm", "rockchip,rk3328-pwm" > "rockchip,rk3308-pwm", "rockchip,rk3328-pwm" > > for pwm nodes to pwm-rockchip.yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Note for rob+dt: > A tag was not added on purpose, because by the change of schema > for clocks and clock-names I add "rockchip,rk3328-pwm" to > the "if:", so strictly speaking V1 and (V2) V3 will not be the same. > Please have a look at it again. > > For some SoC nodes this patch serie generates notifications > for undocumented "interrupts" properties shared between > PWM channels till there is consensus of what to do with it or > someone makes a solution for the whole PWM block. > > Changed V3: > fix mistake with compatibles introduced in V2 > Changed V2: > changed schema for clocks and clock-names > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Apr 12, 2021 at 10:01:53PM +0200, Johan Jonker wrote: > The compatible strings below are already in use in the Rockchip > dtsi files, but were somehow never added to a document, so add > > "rockchip,rk3328-pwm" > > "rockchip,rk3036-pwm", "rockchip,rk2928-pwm" > > "rockchip,rk3368-pwm", "rockchip,rk3288-pwm" > "rockchip,rk3399-pwm", "rockchip,rk3288-pwm" > > "rockchip,px30-pwm", "rockchip,rk3328-pwm" > "rockchip,rk3308-pwm", "rockchip,rk3328-pwm" > > for pwm nodes to pwm-rockchip.yaml. > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Note for rob+dt: > A tag was not added on purpose, because by the change of schema > for clocks and clock-names I add "rockchip,rk3328-pwm" to > the "if:", so strictly speaking V1 and (V2) V3 will not be the same. > Please have a look at it again. > > For some SoC nodes this patch serie generates notifications > for undocumented "interrupts" properties shared between > PWM channels till there is consensus of what to do with it or > someone makes a solution for the whole PWM block. > > Changed V3: > fix mistake with compatibles introduced in V2 > Changed V2: > changed schema for clocks and clock-names > --- > Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Acked-by: Thierry Reding <thierry.reding@gmail.com>
diff --git a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml index 19b42d31d..5596bee70 100644 --- a/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml +++ b/Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml @@ -14,11 +14,22 @@ properties: oneOf: - const: rockchip,rk2928-pwm - const: rockchip,rk3288-pwm + - const: rockchip,rk3328-pwm - const: rockchip,vop-pwm - items: + - const: rockchip,rk3036-pwm + - const: rockchip,rk2928-pwm + - items: - enum: + - rockchip,rk3368-pwm + - rockchip,rk3399-pwm - rockchip,rv1108-pwm - const: rockchip,rk3288-pwm + - items: + - enum: + - rockchip,px30-pwm + - rockchip,rk3308-pwm + - const: rockchip,rk3328-pwm reg: maxItems: 1 @@ -46,6 +57,7 @@ if: compatible: contains: enum: + - rockchip,rk3328-pwm - rockchip,rv1108-pwm then:
The compatible strings below are already in use in the Rockchip dtsi files, but were somehow never added to a document, so add "rockchip,rk3328-pwm" "rockchip,rk3036-pwm", "rockchip,rk2928-pwm" "rockchip,rk3368-pwm", "rockchip,rk3288-pwm" "rockchip,rk3399-pwm", "rockchip,rk3288-pwm" "rockchip,px30-pwm", "rockchip,rk3328-pwm" "rockchip,rk3308-pwm", "rockchip,rk3328-pwm" for pwm nodes to pwm-rockchip.yaml. Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Note for rob+dt: A tag was not added on purpose, because by the change of schema for clocks and clock-names I add "rockchip,rk3328-pwm" to the "if:", so strictly speaking V1 and (V2) V3 will not be the same. Please have a look at it again. For some SoC nodes this patch serie generates notifications for undocumented "interrupts" properties shared between PWM channels till there is consensus of what to do with it or someone makes a solution for the whole PWM block. Changed V3: fix mistake with compatibles introduced in V2 Changed V2: changed schema for clocks and clock-names --- Documentation/devicetree/bindings/pwm/pwm-rockchip.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)