[04/14] pwm: Drop function pwmchip_add_with_polarity()

Message ID	20210319102852.101209-5-u.kleine-koenig@pengutronix.de
State	Rejected
Headers	show Return-Path: <linux-pwm-owner@vger.kernel.org> From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de> To: Thierry Reding <thierry.reding@gmail.com>, Lee Jones <lee.jones@linaro.org> Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de, =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= <uwe@kleine-koenig.org> Subject: [PATCH 04/14] pwm: Drop function pwmchip_add_with_polarity() Date: Fri, 19 Mar 2021 11:28:42 +0100 Message-Id: <20210319102852.101209-5-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210319102852.101209-1-u.kleine-koenig@pengutronix.de> References: <20210319102852.101209-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	pwm: Patches I consider ready for the next merge window \| expand [00/14] pwm: Patches I consider ready for the next merge window [01/14] pwm: bcm2835: Improve period and duty cycle calculation [02/14] pwm: bcm-kona: Use pwmchip_add() instead of pwmchip_add_with_polarity() [03/14] pwm: atmel-hlcdc: Use pwmchip_add() instead of pwmchip_add_with_polarity() [04/14] pwm: Drop function pwmchip_add_with_polarity() [05/14] pwm: ab8500: Implement .apply instead of .config, .enable and .disable [06/14] pwm: imx-tpm: Use a single line for error message [07/14] pwm: Always allocate pwm id dynamically [08/14] pwm: Return -EINVAL for old-style drivers without .set_polarity callback [09/14] pwm: Prevent a glitch in compat code [10/14] pwm: atmel-tcb: Implement .apply callback [11/14] pwm: atmel-tcb: Only free resources after pwm_chip_remove() returned [12/14] pwm: sprd: Refuse requests with unsupported polarity [13/14] pwm: cros-ec: Refuse requests with unsupported polarity [14/14] pwm: Soften potential loss of precision in compat code

Message ID

20210319102852.101209-5-u.kleine-koenig@pengutronix.de

State

Rejected

Headers

From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?=  <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
        Lee Jones <lee.jones@linaro.org>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de, =?utf-8?q?Uwe_Kleine-K?=
	=?utf-8?q?=C3=B6nig?= <uwe@kleine-koenig.org>
Subject: [PATCH 04/14] pwm: Drop function pwmchip_add_with_polarity()
Date: Fri, 19 Mar 2021 11:28:42 +0100
Message-Id: <20210319102852.101209-5-u.kleine-koenig@pengutronix.de>
In-Reply-To: <20210319102852.101209-1-u.kleine-koenig@pengutronix.de>
References: <20210319102852.101209-1-u.kleine-koenig@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

pwm: Patches I consider ready for the next merge window | expand

Commit Message

Uwe Kleine-König March 19, 2021, 10:28 a.m. UTC

From: Uwe Kleine-König <uwe@kleine-koenig.org>

pwmchip_add() only calls pwmchip_add_with_polarity() and nothing else. All
other users of pwmchip_add_with_polarity() are gone. So drop
pwmchip_add_with_polarity() and move the code instead to pwmchip_add().

The initial assignment to pwm->state.polarity is dropped. In every correct
usage of the PWM API this value is overwritten later anyhow.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20201207134556.25217-4-uwe@kleine-koenig.org
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/core.c  | 25 +++----------------------
 include/linux/pwm.h |  2 --
 2 files changed, 3 insertions(+), 24 deletions(-)

diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index a8eff4b3ee36..e7a2d9095669 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -260,18 +260,15 @@  static bool pwm_ops_check(const struct pwm_chip *chip)
 }
 
 /**
- * pwmchip_add_with_polarity() - register a new PWM chip
+ * pwmchip_add() - register a new PWM chip
  * @chip: the PWM chip to add
- * @polarity: initial polarity of PWM channels
  *
  * Register a new PWM chip. If chip->base < 0 then a dynamically assigned base
- * will be used. The initial polarity for all channels is specified by the
- * @polarity parameter.
+ * will be used.
  *
  * Returns: 0 on success or a negative error code on failure.
  */
-int pwmchip_add_with_polarity(struct pwm_chip *chip,
-			      enum pwm_polarity polarity)
+int pwmchip_add(struct pwm_chip *chip)
 {
 	struct pwm_device *pwm;
 	unsigned int i;
@@ -303,7 +300,6 @@  int pwmchip_add_with_polarity(struct pwm_chip *chip,
 		pwm->chip = chip;
 		pwm->pwm = chip->base + i;
 		pwm->hwpwm = i;
-		pwm->state.polarity = polarity;
 
 		radix_tree_insert(&pwm_tree, pwm->pwm, pwm);
 	}
@@ -326,21 +322,6 @@  int pwmchip_add_with_polarity(struct pwm_chip *chip,
 
 	return ret;
 }
-EXPORT_SYMBOL_GPL(pwmchip_add_with_polarity);
-
-/**
- * pwmchip_add() - register a new PWM chip
- * @chip: the PWM chip to add
- *
- * Register a new PWM chip. If chip->base < 0 then a dynamically assigned base
- * will be used. The initial polarity for all channels is normal.
- *
- * Returns: 0 on success or a negative error code on failure.
- */
-int pwmchip_add(struct pwm_chip *chip)
-{
-	return pwmchip_add_with_polarity(chip, PWM_POLARITY_NORMAL);
-}
 EXPORT_SYMBOL_GPL(pwmchip_add);
 
 /**
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index e4d84d4db293..8f4eefd129aa 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -392,8 +392,6 @@  int pwm_capture(struct pwm_device *pwm, struct pwm_capture *result,
 int pwm_set_chip_data(struct pwm_device *pwm, void *data);
 void *pwm_get_chip_data(struct pwm_device *pwm);
 
-int pwmchip_add_with_polarity(struct pwm_chip *chip,
-			      enum pwm_polarity polarity);
 int pwmchip_add(struct pwm_chip *chip);
 int pwmchip_remove(struct pwm_chip *chip);
 struct pwm_device *pwm_request_from_chip(struct pwm_chip *chip,