| Message ID | 20210304024242.2363294-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pwm: imx-tpm: Use a single line for error message | expand |
Hello Fabio, [expanding Cc: a bit] On Wed, Mar 03, 2021 at 11:42:42PM -0300, Fabio Estevam wrote: > There is no need to split the dev_err() call in three lines. > > Use a single line to improve readability. For me the reason to like this change is more to save vertical space without making readability worse, but *shrug*. Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > drivers/pwm/pwm-imx-tpm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c > index aaf629bd8c35..eec9ec4e1a2a 100644 > --- a/drivers/pwm/pwm-imx-tpm.c > +++ b/drivers/pwm/pwm-imx-tpm.c > @@ -411,9 +411,7 @@ static int __maybe_unused pwm_imx_tpm_resume(struct device *dev) > > ret = clk_prepare_enable(tpm->clk); > if (ret) > - dev_err(dev, > - "failed to prepare or enable clock: %d\n", > - ret); > + dev_err(dev, "failed to prepare or enable clock: %d\n", ret); > > return ret; > }
On Wed, Mar 03, 2021 at 11:42:42PM -0300, Fabio Estevam wrote: > There is no need to split the dev_err() call in three lines. > > Use a single line to improve readability. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > --- > drivers/pwm/pwm-imx-tpm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, thanks. Thierry
diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c index aaf629bd8c35..eec9ec4e1a2a 100644 --- a/drivers/pwm/pwm-imx-tpm.c +++ b/drivers/pwm/pwm-imx-tpm.c @@ -411,9 +411,7 @@ static int __maybe_unused pwm_imx_tpm_resume(struct device *dev) ret = clk_prepare_enable(tpm->clk); if (ret) - dev_err(dev, - "failed to prepare or enable clock: %d\n", - ret); + dev_err(dev, "failed to prepare or enable clock: %d\n", ret); return ret; }
There is no need to split the dev_err() call in three lines. Use a single line to improve readability. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/pwm/pwm-imx-tpm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)