| Message ID | 20200706175353.16404-14-michael@walle.cc |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | Add support for Kontron sl28cpld | expand |
Hi Michael, just a drive-by-comment: On Mon, Jul 6, 2020 at 7:57 PM Michael Walle <michael@walle.cc> wrote: > Add a pwm-fan mapped to the PWM channel 0 which is connected to the > fan connector of the carrier. > > Signed-off-by: Michael Walle <michael@walle.cc> If you have a cooling device like this, do you also have a temperature sensor? In that case it makes sense to add a thermal zone and a policy, such as I did for a device in 6e97f0aaca4ca778905dd1dc667cbf379f4cae15 Yours, Linus Walleij
Hi Linus, Am 2020-07-08 09:39, schrieb Linus Walleij: > just a drive-by-comment: > > On Mon, Jul 6, 2020 at 7:57 PM Michael Walle <michael@walle.cc> wrote: > >> Add a pwm-fan mapped to the PWM channel 0 which is connected to the >> fan connector of the carrier. >> >> Signed-off-by: Michael Walle <michael@walle.cc> > > If you have a cooling device like this, do you also have a temperature > sensor? In that case it makes sense to add a thermal zone and a > policy, such as I did for a device in > 6e97f0aaca4ca778905dd1dc667cbf379f4cae15 Yep, the CPU and DDR controller have temperatur sensors and there are already thermal zones for them. We have the fan linked to the policies in our vendor DTS overlay. For now I didn't want to include that here, mainly because there are no labels in the fsl-ls1028a.dtsi for the thermal zone/cooling maps/trips. But this is still on my TODO, when this series finally make it into the kernel ;) -michael
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts index 0973a6a45217..c45d7b40e374 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts @@ -15,6 +15,15 @@ compatible = "kontron,sl28-var3-ads2", "kontron,sl28-var3", "kontron,sl28", "fsl,ls1028a"; + pwm-fan { + compatible = "pwm-fan"; + cooling-min-state = <0>; + cooling-max-state = <3>; + #cooling-cells = <2>; + pwms = <&sl28cpld_pwm0 0 4000000>; + cooling-levels = <1 128 192 255>; + }; + sound { #address-cells = <1>; #size-cells = <0>;
Add a pwm-fan mapped to the PWM channel 0 which is connected to the fan connector of the carrier. Signed-off-by: Michael Walle <michael@walle.cc> --- Changes since v4: - none Changes since v3: - see cover letter .../dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts | 9 +++++++++ 1 file changed, 9 insertions(+)