diff mbox series

[v2,1/4] pwm: jz4740: Drop dependency on MACH_INGENIC

Message ID 20200525125722.36447-1-paul@crapouillou.net
State Changes Requested
Headers show
Series [v2,1/4] pwm: jz4740: Drop dependency on MACH_INGENIC | expand

Commit Message

Paul Cercueil May 25, 2020, 12:57 p.m. UTC
Depending on MACH_INGENIC prevent us from creating a generic kernel that
works on more than one MIPS board. Instead, we just depend on MIPS being
set.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---

Notes:
    v2: No change

 drivers/pwm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Uwe Kleine-König May 25, 2020, 3:33 p.m. UTC | #1
Hello,

On Mon, May 25, 2020 at 02:57:19PM +0200, Paul Cercueil wrote:
> Depending on MACH_INGENIC prevent us from creating a generic kernel that
> works on more than one MIPS board. Instead, we just depend on MIPS being
> set.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Nitpick: Your S-o-B should come last. So if you added my Ack the
resulting commit then has (after being picked up by a maintainer):

 .	Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 .	Signed-off-by: Paul Cercueil <paul@crapouillou.net>
 .	Signed-off-by: Peter Maintainer <...>

(quoted to not let patchwork pick up tags) while when the Ack is added
by the maintainer the result is

 .	Signed-off-by: Paul Cercueil <paul@crapouillou.net>
 .	Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 .	Signed-off-by: Peter Maintainer <...>

. So the order tells the reader who added a tag.

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
index eebbc917ac97..7814e5b2cad7 100644
--- a/drivers/pwm/Kconfig
+++ b/drivers/pwm/Kconfig
@@ -234,7 +234,7 @@  config PWM_IMX_TPM
 
 config PWM_JZ4740
 	tristate "Ingenic JZ47xx PWM support"
-	depends on MACH_INGENIC
+	depends on MIPS
 	depends on COMMON_CLK
 	select MFD_SYSCON
 	help