Message ID | 20200415182639.18534-1-robh@kernel.org |
---|---|
State | Accepted |
Headers | show |
Series | dt-bindings: pwm: Fix cros-ec-pwm example dtc 'reg' warning | expand |
Hello Rob, On Wed, Apr 15, 2020 at 01:26:39PM -0500, Rob Herring wrote: > The example for the CrOS EC PWM is incomplete and now generates a dtc > warning: > > Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.example.dts:17.11-23.11: > Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg or ranges property > > Fixing this results in more warnings as a parent spi node is needed as > well. > > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> > Cc: Benson Leung <bleung@chromium.org> > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Cc: Guenter Roeck <groeck@chromium.org> > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../bindings/pwm/google,cros-ec-pwm.yaml | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml > index 24c217b76580..41ece1d85315 100644 > --- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml > +++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml > @@ -31,10 +31,17 @@ additionalProperties: false > > examples: > - | > - cros-ec@0 { > - compatible = "google,cros-ec-spi"; > - cros_ec_pwm: ec-pwm { > - compatible = "google,cros-ec-pwm"; > - #pwm-cells = <1>; > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + cros-ec@0 { > + compatible = "google,cros-ec-spi"; > + reg = <0>; > + > + cros_ec_pwm: ec-pwm { > + compatible = "google,cros-ec-pwm"; > + #pwm-cells = <1>; > + }; Looks reasonable Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Is this supposed to go via the pwm tree, or do you apply yourself via a device-tree tree? Best regards Uwe
On Wed, Apr 15, 2020 at 2:29 PM Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > > Hello Rob, > > On Wed, Apr 15, 2020 at 01:26:39PM -0500, Rob Herring wrote: > > The example for the CrOS EC PWM is incomplete and now generates a dtc > > warning: > > > > Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.example.dts:17.11-23.11: > > Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg or ranges property > > > > Fixing this results in more warnings as a parent spi node is needed as > > well. > > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> > > Cc: Benson Leung <bleung@chromium.org> > > Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Cc: Guenter Roeck <groeck@chromium.org> > > Cc: linux-pwm@vger.kernel.org > > Signed-off-by: Rob Herring <robh@kernel.org> > > --- > > .../bindings/pwm/google,cros-ec-pwm.yaml | 17 ++++++++++++----- > > 1 file changed, 12 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml > > index 24c217b76580..41ece1d85315 100644 > > --- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml > > @@ -31,10 +31,17 @@ additionalProperties: false > > > > examples: > > - | > > - cros-ec@0 { > > - compatible = "google,cros-ec-spi"; > > - cros_ec_pwm: ec-pwm { > > - compatible = "google,cros-ec-pwm"; > > - #pwm-cells = <1>; > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cros-ec@0 { > > + compatible = "google,cros-ec-spi"; > > + reg = <0>; > > + > > + cros_ec_pwm: ec-pwm { > > + compatible = "google,cros-ec-pwm"; > > + #pwm-cells = <1>; > > + }; > > Looks reasonable > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks. > Is this supposed to go via the pwm tree, or do you apply yourself via a > device-tree tree? I'll take it for rc2. Rob
diff --git a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml index 24c217b76580..41ece1d85315 100644 --- a/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml +++ b/Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml @@ -31,10 +31,17 @@ additionalProperties: false examples: - | - cros-ec@0 { - compatible = "google,cros-ec-spi"; - cros_ec_pwm: ec-pwm { - compatible = "google,cros-ec-pwm"; - #pwm-cells = <1>; + spi { + #address-cells = <1>; + #size-cells = <0>; + + cros-ec@0 { + compatible = "google,cros-ec-spi"; + reg = <0>; + + cros_ec_pwm: ec-pwm { + compatible = "google,cros-ec-pwm"; + #pwm-cells = <1>; + }; }; };
The example for the CrOS EC PWM is incomplete and now generates a dtc warning: Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.example.dts:17.11-23.11: Warning (unit_address_vs_reg): /example-0/cros-ec@0: node has a unit name, but no reg or ranges property Fixing this results in more warnings as a parent spi node is needed as well. Cc: Thierry Reding <thierry.reding@gmail.com> Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de> Cc: Benson Leung <bleung@chromium.org> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Guenter Roeck <groeck@chromium.org> Cc: linux-pwm@vger.kernel.org Signed-off-by: Rob Herring <robh@kernel.org> --- .../bindings/pwm/google,cros-ec-pwm.yaml | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)