From patchwork Mon Mar 23 09:24:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rayagonda Kokatanur X-Patchwork-Id: 1259925 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pwm-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=H0/vrJJc; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48m89P2m3Cz9sRY for ; Mon, 23 Mar 2020 20:24:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727754AbgCWJYy (ORCPT ); Mon, 23 Mar 2020 05:24:54 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46022 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727726AbgCWJYx (ORCPT ); Mon, 23 Mar 2020 05:24:53 -0400 Received: by mail-pg1-f193.google.com with SMTP id o26so387236pgc.12 for ; Mon, 23 Mar 2020 02:24:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=A/0NRUsfnu7n/YoGxddH0xC1BSLSDDMn2mXtHQEsBCY=; b=H0/vrJJc4UTp4a1L7+UIrsXgbN2ZX+7FVzPetQZIdA9e76ziulDaDd2NAhYkIPjkxS YT987yydfco9sXyReNE47Uy1nFABe5RZIGH+tsYqgmg60OQudmltQHH7WVpP7G8VHogy +GLzGp5ZIudGxaUkMdcxKmubUoLfIMq6950kg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=A/0NRUsfnu7n/YoGxddH0xC1BSLSDDMn2mXtHQEsBCY=; b=Kbu2SL4+wCG62MZYQoFoUA6D+py6DrXsBX0lTmgXgJF0JyQpFiNCeENP5unjeE0Mek ufA0IS/hpepsTIdpNZNLaPmyls5M5mXkUjth+Z/5j+B8/yAZ7PPCA/H6QowZifOrCuXc PO/H8dvQ1zXqpWY734MOkU5Fr487joA/lk9Eni0pGIJkbuicgs7dGhzcSOfZ5oIdOWe7 QXEX/ZVAE68aQI75IBgQxwar4nGs5gikYv88/Yb9xL9KtamDZrBJg6YTcBk5KOCq7pCq eLLmG3BMp/YL5SopBRT6GVMSV9YOFVPFa+ySM3DXNK+TT2rfmsvyW58tP5nUJvezgZsr 4LWQ== X-Gm-Message-State: ANhLgQ1l78Dta5fMwKHGanYxcaZGgErV7eQFGF7/EYK1oqcKtb+YUZGo 8UWXu1OxiBpu1gh3U8xBr1pdCw== X-Google-Smtp-Source: ADFU+vsQVINq2XB12jFlGwrLlldGkGz/5WxUV8cQYnSGPxofZHvKAe+lIqQmXoaWxjTZF4JRtCVP8w== X-Received: by 2002:a63:794d:: with SMTP id u74mr8709869pgc.15.1584955492897; Mon, 23 Mar 2020 02:24:52 -0700 (PDT) Received: from rayagonda.dhcp.broadcom.net ([192.19.234.250]) by smtp.gmail.com with ESMTPSA id t186sm1093068pgd.43.2020.03.23.02.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Mar 2020 02:24:52 -0700 (PDT) From: Rayagonda Kokatanur To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K?= =?utf-8?b?w7ZuaWc=?= , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Yendapally Reddy Dhananjaya Reddy , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Rayagonda Kokatanur Subject: [PATCH v2 2/2] pwm: bcm-iproc: remove unnecessary check of 'duty' Date: Mon, 23 Mar 2020 14:54:24 +0530 Message-Id: <20200323092424.22664-3-rayagonda.kokatanur@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200323092424.22664-1-rayagonda.kokatanur@broadcom.com> References: <20200323092424.22664-1-rayagonda.kokatanur@broadcom.com> Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Variable 'duty' is u32 and IPROC_PWM_DUTY_CYCLE_MIN is zero. Hence the less-than zero comparison is never true,remove the check. Fixes: daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller") Signed-off-by: Rayagonda Kokatanur --- drivers/pwm/pwm-bcm-iproc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c index 8bbd2a04fead..1bb66721f985 100644 --- a/drivers/pwm/pwm-bcm-iproc.c +++ b/drivers/pwm/pwm-bcm-iproc.c @@ -149,8 +149,7 @@ static int iproc_pwmc_apply(struct pwm_chip *chip, struct pwm_device *pwm, value = rate * state->duty_cycle; duty = div64_u64(value, div); - if (period < IPROC_PWM_PERIOD_MIN || - duty < IPROC_PWM_DUTY_CYCLE_MIN) + if (period < IPROC_PWM_PERIOD_MIN) return -EINVAL; if (period <= IPROC_PWM_PERIOD_MAX &&