diff mbox series

hwmon: (pwm-fan): Switch to using the new API kobj_to_dev()

Message ID 1606525206-22154-1-git-send-email-tiantao6@hisilicon.com
State Not Applicable
Headers show
Series hwmon: (pwm-fan): Switch to using the new API kobj_to_dev() | expand

Commit Message

Tian Tao Nov. 28, 2020, 1 a.m. UTC
fixed the following coccicheck:
drivers/hwmon//pwm-fan.c:152:60-61: WARNING opportunity for kobj_to_dev().

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/hwmon/pwm-fan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guenter Roeck Nov. 28, 2020, 8:23 p.m. UTC | #1
On Sat, Nov 28, 2020 at 09:00:06AM +0800, Tian Tao wrote:
> fixed the following coccicheck:
> drivers/hwmon//pwm-fan.c:152:60-61: WARNING opportunity for kobj_to_dev().
> 
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>

With the switch to use devm_hwmon_device_register_with_info() instead of
devm_hwmon_device_register_with_groups(), this patch is no longer necessary.
Please see tip of hwmon-next.

Thanks,
Guenter

> ---
>  drivers/hwmon/pwm-fan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
> index 1f63807..7849011 100644
> --- a/drivers/hwmon/pwm-fan.c
> +++ b/drivers/hwmon/pwm-fan.c
> @@ -149,7 +149,7 @@ static struct attribute *pwm_fan_attrs[] = {
>  static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a,
>  				     int n)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
>  
>  	/* Hide fan_input in case no interrupt is available  */
diff mbox series

Patch

diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 1f63807..7849011 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -149,7 +149,7 @@  static struct attribute *pwm_fan_attrs[] = {
 static umode_t pwm_fan_attrs_visible(struct kobject *kobj, struct attribute *a,
 				     int n)
 {
-	struct device *dev = container_of(kobj, struct device, kobj);
+	struct device *dev = kobj_to_dev(kobj);
 	struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
 
 	/* Hide fan_input in case no interrupt is available  */