| Message ID | 1589723560-5734-4-git-send-email-vineetha.g.jaya.kumaran@intel.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add PWM support for Intel Keem Bay SoC | expand |
On Sun, 17 May 2020 21:52:40 +0800, wrote: > From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com> > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com> > --- > .../devicetree/bindings/pwm/pwm-keembay.yaml | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/pwm/pwm-keembay.example.dts:22.31-32 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:312: recipe for target 'Documentation/devicetree/bindings/pwm/pwm-keembay.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/pwm/pwm-keembay.example.dt.yaml] Error 1 Makefile:1300: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1292157 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Sun, May 17, 2020 at 09:52:40PM +0800, vineetha.g.jaya.kumaran@intel.com wrote: > From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com> > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > Signed-off-by: Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com> > --- > .../devicetree/bindings/pwm/pwm-keembay.yaml | 39 ++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-keembay.yaml Use compatible string for filename: intel,keembay-pwn.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > new file mode 100644 > index 0000000..00968d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > @@ -0,0 +1,39 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2020 Intel Corporation > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/pwm-keembay.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel Keem Bay PWM Device Tree Bindings > + > +maintainers: > + - Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com> > + > +allOf: > + - $ref: pwm.yaml# > + > +properties: > + compatible: > + enum: > + - intel,keembay-pwm > + > + reg: > + maxItems: 1 > + > + clocks: > + description: > + phandle to the reference clock. How many clocks? (maxItems: 1?) You can drop the description. > + > +required: > + - compatible > + - reg > + - clocks > + > +examples: > + - | > + pwm@203200a0 { > + compatible = "intel,keembay-pwm"; > + reg = <0x0 0x203200a0 0x0 0xe8>; > + clocks = <&scmi_clk KEEM_BAY_A53_GPIO>; > + }; > -- > 1.9.1 >
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Monday, May 18, 2020 10:19 PM > To: G Jaya Kumaran, Vineetha <vineetha.g.jaya.kumaran@intel.com> > Cc: devicetree@vger.kernel.org; u.kleine-koenig@pengutronix.de; Wan > Mohamad, Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; > robh+dt@kernel.org; linux-pwm@vger.kernel.org; Shevchenko, Andriy > <andriy.shevchenko@intel.com>; thierry.reding@gmail.com > Subject: Re: [PATCH 3/3] dt-bindings: pwm: keembay: Add bindings for Intel > Keem Bay PWM > > On Sun, 17 May 2020 21:52:40 +0800, wrote: > > From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com> > > > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > > > Signed-off-by: Vineetha G. Jaya Kumaran > > <vineetha.g.jaya.kumaran@intel.com> > > --- > > .../devicetree/bindings/pwm/pwm-keembay.yaml | 39 > ++++++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/pwm/pwm- > keembay.example.dts:22.31-32 syntax error FATAL ERROR: Unable to parse > input tree > scripts/Makefile.lib:312: recipe for target > 'Documentation/devicetree/bindings/pwm/pwm-keembay.example.dt.yaml' > failed > make[1]: *** [Documentation/devicetree/bindings/pwm/pwm- > keembay.example.dt.yaml] Error 1 > Makefile:1300: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1292157 > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master -- > upgrade > > Please check and re-submit. Thank you for reviewing. Will check this again and make sure it passes before submitting v2.
> -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Monday, May 18, 2020 10:22 PM > To: G Jaya Kumaran, Vineetha <vineetha.g.jaya.kumaran@intel.com> > Cc: thierry.reding@gmail.com; u.kleine-koenig@pengutronix.de; linux- > pwm@vger.kernel.org; devicetree@vger.kernel.org; Wan Mohamad, Wan > Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>; Shevchenko, > Andriy <andriy.shevchenko@intel.com> > Subject: Re: [PATCH 3/3] dt-bindings: pwm: keembay: Add bindings for Intel > Keem Bay PWM > > On Sun, May 17, 2020 at 09:52:40PM +0800, > vineetha.g.jaya.kumaran@intel.com wrote: > > From: "Vineetha G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com> > > > > Add PWM Device Tree bindings documentation for the Intel Keem Bay SoC. > > > > Signed-off-by: Vineetha G. Jaya Kumaran > > <vineetha.g.jaya.kumaran@intel.com> > > --- > > .../devicetree/bindings/pwm/pwm-keembay.yaml | 39 > ++++++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > Use compatible string for filename: intel,keembay-pwn.yaml > Will fix the filename in v2. > > > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > new file mode 100644 > > index 0000000..00968d7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml > > @@ -0,0 +1,39 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license new bindings: > > (GPL-2.0-only OR BSD-2-Clause) > OK, will update the licensing info. > > +# Copyright (C) 2020 Intel Corporation %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pwm/pwm-keembay.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Intel Keem Bay PWM Device Tree Bindings > > + > > +maintainers: > > + - Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com> > > + > > +allOf: > > + - $ref: pwm.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - intel,keembay-pwm > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: > > + phandle to the reference clock. > > How many clocks? (maxItems: 1?) > > You can drop the description. > 1 clock is needed for this case, will add in maxItems and drop the description. > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + > > +examples: > > + - | > > + pwm@203200a0 { > > + compatible = "intel,keembay-pwm"; > > + reg = <0x0 0x203200a0 0x0 0xe8>; > > + clocks = <&scmi_clk KEEM_BAY_A53_GPIO>; > > + }; > > -- > > 1.9.1 > >
diff --git a/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml new file mode 100644 index 0000000..00968d7 --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-keembay.yaml @@ -0,0 +1,39 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright (C) 2020 Intel Corporation +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/pwm-keembay.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Intel Keem Bay PWM Device Tree Bindings + +maintainers: + - Vineetha G. Jaya Kumaran <vineetha.g.jaya.kumaran@intel.com> + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + enum: + - intel,keembay-pwm + + reg: + maxItems: 1 + + clocks: + description: + phandle to the reference clock. + +required: + - compatible + - reg + - clocks + +examples: + - | + pwm@203200a0 { + compatible = "intel,keembay-pwm"; + reg = <0x0 0x203200a0 0x0 0xe8>; + clocks = <&scmi_clk KEEM_BAY_A53_GPIO>; + };