From patchwork Fri Apr 21 13:19:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Van Asbroeck X-Patchwork-Id: 753397 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3w8btR2Ypkz9s4s for ; Fri, 21 Apr 2017 23:19:27 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="MmPRgxQP"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1039798AbdDUNTL (ORCPT ); Fri, 21 Apr 2017 09:19:11 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:35416 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1039796AbdDUNTH (ORCPT ); Fri, 21 Apr 2017 09:19:07 -0400 Received: by mail-io0-f195.google.com with SMTP id d203so30385369iof.2; Fri, 21 Apr 2017 06:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=Z6tNsuW5wzYbcAvgqpjiRozMsHYohBwe8wIF1b4tvGs=; b=MmPRgxQPfLmr8q1oU7HffGWF2/ZLkRVRiYbVo9NUiuid0dA8P+avF/DRA6fzp8f2q8 yUuufCcawkmFzC17BYzXhga/8F/Nxd07VwXqV3JtsYTeIUoOa4+Ou3T9jCEUnYSuElo3 52Kx2b+cz3TCRhbYYKJbzrAslwkKIbZhrPKL/xoth+HPvYnOuf/tO6zkbUMDapMC2qnQ XohbIZFx+wQs3lta4j0AdAnIPCwGagZ9pZp623kWKwSuQw9iGTMkhwjo2vqj/WIAsOXD KEmCA371/ObEtKHgZU/HXp/obF4BCR8loczm09v+tUpHaFl0rBQxVavaFGbJmSQOZqPi lQfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Z6tNsuW5wzYbcAvgqpjiRozMsHYohBwe8wIF1b4tvGs=; b=GjehC98Nyk1rVNYnGjbZ0cjGWncqwvMYx+K5HUuNlXWe2/ytZ2Uz16uQPsD0A7telj imQliSM01hZ/2GmTpTbIIfxs9NCTKc3qKOH4RIFlGQxbDXmKLAR/mo9svpoApubKaqNS dc4C6heV+/dspiyB7hTLjtxW6UEIa3b/ij+KVUgI59IG4+LqNc1DaLgnrv3lGtGLRCC3 vKRxSRM2AiI+JZ/r3qbjuhspvIjpCDwlkGbt3HMjoiI1ByJ0kw8D/t66V+U6D35FSFCL jozptoqaQKltLohj+y28RP6LBiKRnGu3Lm2TsYCF5+C7NES1MGlzcM8+/AqhnLNr2KmW 0Kgw== X-Gm-Message-State: AN3rC/4SaFuM6a68+RFbmR+Om2zsNPlJ054ZdRcLPrgPjE+GYjZhoEPN eLVvH6HEx2HPCw== X-Received: by 10.107.10.103 with SMTP id u100mr14932259ioi.76.1492780746071; Fri, 21 Apr 2017 06:19:06 -0700 (PDT) Received: from trappist.arcx.com ([184.94.50.30]) by smtp.googlemail.com with ESMTPSA id j5sm539612iti.20.2017.04.21.06.19.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 21 Apr 2017 06:19:05 -0700 (PDT) From: Sven Van Asbroeck To: thierry.reding@gmail.com Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com Subject: [PATCH v1] pwm: pca9685: clarify pca9685_set_sleep_mode() interface. Date: Fri, 21 Apr 2017 09:19:02 -0400 Message-Id: <1492780742-11251-1-git-send-email-thesven73@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org The function static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep) takes the chip in and out of sleep mode, depending on the value of sleep, which is interpreted as a boolean. To clarify that 'int sleep' is a boolean and not a sleep delay, change the function interface to: static void pca9685_set_sleep_mode(struct pca9685 *pca, bool enable) Suggested-by: Andy Shevchenko Signed-off-by: Sven Van Asbroeck Reviewed-by: Andy Shevchenko --- drivers/pwm/pwm-pca9685.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 5f55cfa..a7eaf962 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -241,11 +241,11 @@ static inline int pca9685_pwm_gpio_probe(struct pca9685 *pca) } #endif -static void pca9685_set_sleep_mode(struct pca9685 *pca, int sleep) +static void pca9685_set_sleep_mode(struct pca9685 *pca, bool enable) { regmap_update_bits(pca->regmap, PCA9685_MODE1, - MODE1_SLEEP, sleep ? MODE1_SLEEP : 0); - if (!sleep) { + MODE1_SLEEP, enable ? MODE1_SLEEP : 0); + if (!enable) { /* Wait 500us for the oscillator to be back up */ udelay(500); } @@ -272,13 +272,13 @@ static int pca9685_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm, * state is guaranteed active here. */ /* Put chip into sleep mode */ - pca9685_set_sleep_mode(pca, 1); + pca9685_set_sleep_mode(pca, true); /* Change the chip-wide output frequency */ regmap_write(pca->regmap, PCA9685_PRESCALE, prescale); /* Wake the chip up */ - pca9685_set_sleep_mode(pca, 0); + pca9685_set_sleep_mode(pca, false); pca->period_ns = period_ns; } else { @@ -534,7 +534,7 @@ static int pca9685_pwm_runtime_suspend(struct device *dev) struct i2c_client *client = to_i2c_client(dev); struct pca9685 *pca = i2c_get_clientdata(client); - pca9685_set_sleep_mode(pca, 1); + pca9685_set_sleep_mode(pca, true); return 0; } @@ -543,7 +543,7 @@ static int pca9685_pwm_runtime_resume(struct device *dev) struct i2c_client *client = to_i2c_client(dev); struct pca9685 *pca = i2c_get_clientdata(client); - pca9685_set_sleep_mode(pca, 0); + pca9685_set_sleep_mode(pca, false); return 0; } #endif