From patchwork Tue Nov 1 10:46:39 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 689810 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t7SbL15MSz9svs for ; Tue, 1 Nov 2016 21:46:54 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=JS4HNj7X; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1168694AbcKAKqx (ORCPT ); Tue, 1 Nov 2016 06:46:53 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:34825 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1168654AbcKAKqw (ORCPT ); Tue, 1 Nov 2016 06:46:52 -0400 Received: by mail-lf0-f65.google.com with SMTP id p100so4227925lfg.2; Tue, 01 Nov 2016 03:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=+f+iQHCTQcZdwTuYsJnUTyp2wvBi9Ah8qXY8R9W3SFM=; b=JS4HNj7XMkFZ+ZK3KH/0d2GnvjhtfQmuQPX8pOW1kRudWnCYm7efXADrTOR1Ka5PV6 c3XsCTT/a5qPrp4lRkrPcU1y/El/f8N+OkbVmRXyTPFyBi3iLS1eC5I9sjFUiQkcbstf ZsMxxu8xchGlyVlTgbz0FW6bVazNEIEZqvzn2x4lqJDoU2wyHtZWolyuk81QlxTZ0NVn 2kEKHjPQAb1yaq7x7+4mdGwC56Thl5r//EsV4jLLwTCs/q7ZBAuNNT3m1YSZkolPeERg 9TVKd9q0iiJua94vnWXqWp+3xbegF+cx4aKf1n5sJfRqxiWQvv6coDVB51BCHtYKD0Pi Z8UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=+f+iQHCTQcZdwTuYsJnUTyp2wvBi9Ah8qXY8R9W3SFM=; b=hWc/OTszJIoEn7m1HB7oTKPnqIiopWzcYPQZvMAwAwNdQxDdG1DtGm86mzg4i3SW9h bd2vrL7/RcO87iCnW0iTysjWcWiW5ISoWBokmWQHVkeBwbGjCdB/3WHfhJZnAIudEnC6 rgceup3GQbtbeQADr+vfzBuZu5Uqxto/M0RSpC8lHvZjGsuZHkOQLOiRNkcxMExyd0mL 1IrMho0vfLGTWPTqrYAuiTM64ka221mIslUavKbmPQ7JNtVxPiSMWtONTx41aDkq5Geu QIrCGN/ayIHSL1R1mYU9Jzxr6XK3dJ6hRs8vt9pBqn58Cdmb37nzGaAS6KhqxRjh36jV C15g== X-Gm-Message-State: ABUngvd22a20o80XiXT4PkxKuv3HuCVpeOjQKyDNjxOUVPhF2aMLBzqPF9tgSvSeNypRYg== X-Received: by 10.25.169.146 with SMTP id s140mr16898206lfe.24.1477997210319; Tue, 01 Nov 2016 03:46:50 -0700 (PDT) Received: from xi.terra (c-04aadb54.07-184-6d6c6d4.cust.bredbandsbolaget.se. [84.219.170.4]) by smtp.gmail.com with ESMTPSA id h29sm2422161lfj.22.2016.11.01.03.46.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 03:46:49 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.87) (envelope-from ) id 1c1Waf-0007dL-7w; Tue, 01 Nov 2016 11:46:49 +0100 From: Johan Hovold To: Thierry Reding Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH] pwm: fix device reference leak Date: Tue, 1 Nov 2016 11:46:39 +0100 Message-Id: <1477997199-29305-1-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.7.3 Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org Make sure to drop the reference to the parent device taken by class_find_device() after "unexporting" any children when deregistering a pwm chip. Fixes: 0733424c9ba9 ("pwm: Unexport children before chip removal") Signed-off-by: Johan Hovold --- drivers/pwm/sysfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c index 0296d8178ae2..a813239300c3 100644 --- a/drivers/pwm/sysfs.c +++ b/drivers/pwm/sysfs.c @@ -425,6 +425,8 @@ void pwmchip_sysfs_unexport_children(struct pwm_chip *chip) if (test_bit(PWMF_EXPORTED, &pwm->flags)) pwm_unexport_child(parent, pwm); } + + put_device(parent); } static int __init pwm_sysfs_init(void)