| Message ID | 1426170508-8273-1-git-send-email-qipeng.zha@intel.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote: > From: "qipeng.zha" <qipeng.zha@intel.com> > > Add pci device id for Broxton platform. For reference, this should be "PCI" and "ID", but I can fix those up while applying. Also, it's customary to include a changelog in subsequent versions of a patch, as well as change the subject prefix to include the patch version number. That makes it easier for other people to track things. You can do so using: $ git format-patch --subject-prefix='PATCH v2' ... The changelog typically goes below the --- marker (the one below the Signed-off-by line) and would look something like this: --- Changes in v2: - keep board information table sorted by device ID - reuse Braswell board information Again, no need to resend this time, but something to keep in mind for future patches. > Signed-off-by: qipeng.zha <qipeng.zha@intel.com> I'd prefer a proper spelling of your name. Would "Qipeng Zha" be correct? Thierry
On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote: > From: "qipeng.zha" <qipeng.zha@intel.com> > > Add pci device id for Broxton platform. > > Signed-off-by: qipeng.zha <qipeng.zha@intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Thierry Thank you very much:) Best wishes Qipeng -----Original Message----- From: linux-pwm-owner@vger.kernel.org [mailto:linux-pwm-owner@vger.kernel.org] On Behalf Of Thierry Reding Sent: Thursday, March 12, 2015 3:59 PM To: Zha, Qipeng Cc: linux-pwm@vger.kernel.org; Westerberg, Mika Subject: Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote: > From: "qipeng.zha" <qipeng.zha@intel.com> > > Add pci device id for Broxton platform. For reference, this should be "PCI" and "ID", but I can fix those up while applying. Also, it's customary to include a changelog in subsequent versions of a patch, as well as change the subject prefix to include the patch version number. That makes it easier for other people to track things. You can do so using: $ git format-patch --subject-prefix='PATCH v2' ... The changelog typically goes below the --- marker (the one below the Signed-off-by line) and would look something like this: --- Changes in v2: - keep board information table sorted by device ID - reuse Braswell board information Again, no need to resend this time, but something to keep in mind for future patches. > Signed-off-by: qipeng.zha <qipeng.zha@intel.com> I'd prefer a proper spelling of your name. Would "Qipeng Zha" be correct? Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-pwm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks like I never got around to applying this. Done now. Thierry On Fri, Mar 13, 2015 at 12:51:35AM +0000, Zha, Qipeng wrote: > Thierry > > Thank you very much:) > > > Best wishes > Qipeng > > -----Original Message----- > From: linux-pwm-owner@vger.kernel.org [mailto:linux-pwm-owner@vger.kernel.org] On Behalf Of Thierry Reding > Sent: Thursday, March 12, 2015 3:59 PM > To: Zha, Qipeng > Cc: linux-pwm@vger.kernel.org; Westerberg, Mika > Subject: Re: [PATCH] pwm: update lpss pwm driver to support Broxton platform > > On Thu, Mar 12, 2015 at 10:28:28PM +0800, qipeng.zha wrote: > > From: "qipeng.zha" <qipeng.zha@intel.com> > > > > Add pci device id for Broxton platform. > > For reference, this should be "PCI" and "ID", but I can fix those up while applying. > > Also, it's customary to include a changelog in subsequent versions of a patch, as well as change the subject prefix to include the patch version number. That makes it easier for other people to track things. > > You can do so using: > > $ git format-patch --subject-prefix='PATCH v2' ... > > The changelog typically goes below the --- marker (the one below the Signed-off-by line) and would look something like this: > > --- > Changes in v2: > - keep board information table sorted by device ID > - reuse Braswell board information > > Again, no need to resend this time, but something to keep in mind for future patches. > > > Signed-off-by: qipeng.zha <qipeng.zha@intel.com> > > I'd prefer a proper spelling of your name. Would "Qipeng Zha" be correct? > > Thierry
diff --git a/drivers/pwm/pwm-lpss-pci.c b/drivers/pwm/pwm-lpss-pci.c index cf20d2b..45042c1 100644 --- a/drivers/pwm/pwm-lpss-pci.c +++ b/drivers/pwm/pwm-lpss-pci.c @@ -44,8 +44,10 @@ static void pwm_lpss_remove_pci(struct pci_dev *pdev) } static const struct pci_device_id pwm_lpss_pci_ids[] = { + { PCI_VDEVICE(INTEL, 0x0ac8), (unsigned long)&pwm_lpss_bsw_info}, { PCI_VDEVICE(INTEL, 0x0f08), (unsigned long)&pwm_lpss_byt_info}, { PCI_VDEVICE(INTEL, 0x0f09), (unsigned long)&pwm_lpss_byt_info}, + { PCI_VDEVICE(INTEL, 0x1ac8), (unsigned long)&pwm_lpss_bsw_info}, { PCI_VDEVICE(INTEL, 0x2288), (unsigned long)&pwm_lpss_bsw_info}, { PCI_VDEVICE(INTEL, 0x2289), (unsigned long)&pwm_lpss_bsw_info}, { },