| Message ID | CAPgLHd_B-RBGTcQPeeWeJb9QVkf-RjO1WtBC0JK2KOEoBaus_Q@mail.gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Dear Wei Yongjun, On Mon, 27 May 2013 11:38:41 +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > In case of error, function of_clk_get_by_name() returns > ERR_PTR() never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Jason, this needs to be in the mvebu/pcie branch, so I'll guess you would have to rebase mvebu/pcie_bridge on top of it. Thanks! Thomas
All, On Mon, May 27, 2013 at 11:38:41AM +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > > In case of error, function of_clk_get_by_name() returns > ERR_PTR() never returns NULL. The NULL test in the return > value check should be replaced with IS_ERR(). > > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> > --- > drivers/pci/host/pci-mvebu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to mvebu/pcie. FYI: mvebu/pcie_bridge, and mvebu/pcie_kirkwood have been rebased on top of this change. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c index 91106df..c8397c4 100644 --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c @@ -828,7 +828,7 @@ static int __init mvebu_pcie_probe(struct platform_device *pdev) } port->clk = of_clk_get_by_name(child, NULL); - if (!port->clk) { + if (IS_ERR(port->clk)) { dev_err(&pdev->dev, "PCIe%d.%d: cannot get clock\n", port->port, port->lane); iounmap(port->base);