From patchwork Mon Dec 16 08:34:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Gordeev X-Patchwork-Id: 301778 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C470F2C009F for ; Tue, 17 Dec 2013 05:40:52 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550Ab3LPSkv (ORCPT ); Mon, 16 Dec 2013 13:40:51 -0500 Received: from 221-186-24-89.in-addr.arpa ([89.24.186.221]:28455 "EHLO dhcp-26-207.brq.redhat.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754143Ab3LPSku (ORCPT ); Mon, 16 Dec 2013 13:40:50 -0500 X-Greylist: delayed 328 seconds by postgrey-1.27 at vger.kernel.org; Mon, 16 Dec 2013 13:40:50 EST Received: from dhcp-26-207.brq.redhat.com (localhost [127.0.0.1]) by dhcp-26-207.brq.redhat.com (8.14.5/8.14.5) with ESMTP id rBG8ZWQO016622; Mon, 16 Dec 2013 09:35:33 +0100 Received: (from agordeev@localhost) by dhcp-26-207.brq.redhat.com (8.14.5/8.14.5/Submit) id rBG8ZW39016621; Mon, 16 Dec 2013 09:35:32 +0100 From: Alexander Gordeev To: linux-kernel@vger.kernel.org Cc: Alexander Gordeev , Bjorn Helgaas , Michael Ellerman , Benjamin Herrenschmidt , Tejun Heo , Ben Hutchings , David Laight , Mark Lord , "H. Peter Anvin" , linux-pci@vger.kernel.org Subject: [PATCH v4 3/9] PCI/MSI: Fix return value when populate_msi_sysfs() failed Date: Mon, 16 Dec 2013 09:34:56 +0100 Message-Id: <798797dbdc198cb4d6fbb08c2e431558e56f51b8.1387140921.git.agordeev@redhat.com> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: References: Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org If populate_msi_sysfs() function failed msix_capability_init() must return the error code, but it returns the success instead. This update fixes the described misbehaviour. Signed-off-by: Alexander Gordeev Reviewed-by: Tejun Heo --- drivers/pci/msi.c | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index c0baa3d..623322d 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -740,7 +740,7 @@ static int msix_capability_init(struct pci_dev *dev, ret = arch_setup_msi_irqs(dev, nvec, PCI_CAP_ID_MSIX); if (ret) - goto error; + goto out_avail; /* * Some devices require MSI-X to be enabled before we can touch the @@ -753,10 +753,8 @@ static int msix_capability_init(struct pci_dev *dev, msix_program_entries(dev, entries); ret = populate_msi_sysfs(dev); - if (ret) { - ret = 0; - goto error; - } + if (ret) + goto out_free; /* Set MSI-X enabled bits and unmask the function */ pci_intx_for_msi(dev, 0); @@ -767,7 +765,7 @@ static int msix_capability_init(struct pci_dev *dev, return 0; -error: +out_avail: if (ret < 0) { /* * If we had some success, report the number of irqs @@ -784,6 +782,7 @@ error: ret = avail; } +out_free: free_msi_irqs(dev); return ret;