From patchwork Wed May 20 15:41:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen Hubbe X-Patchwork-Id: 474651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0CC9F14029E for ; Thu, 21 May 2015 06:46:50 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=emc.com header.i=@emc.com header.b=L545hdt0; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754712AbbETUqb (ORCPT ); Wed, 20 May 2015 16:46:31 -0400 Received: from mailuogwhop.emc.com ([168.159.213.141]:39135 "EHLO mailuogwhop.emc.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754710AbbETUmF (ORCPT ); Wed, 20 May 2015 16:42:05 -0400 Received: from maildlpprd04.lss.emc.com (maildlpprd04.lss.emc.com [10.253.24.36]) by mailuogwprd04.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t4KKg1TZ030380 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 May 2015 16:42:02 -0400 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com t4KKg1TZ030380 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=emc.com; s=jan2013; t=1432154523; bh=JRRMwsGiSq4abKlrBlvho9ByFEI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: In-Reply-To:References; b=L545hdt0PskzC0BVsDVi3sIRcCFznkdPrl05wsSOorb9Ug1PfzAMng2rV7Eehy4A4 UHR2riWZ7C3Iy+MqvZpw7tq0dwlYmimt+S3EyfYsoCx2tWCxC722zKs9EwhdwZmDpJ 9adwDK1OhVqqlhefyVVHfjVh2QvqMSIievp4zIok= X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd04.lss.emc.com t4KKg1TZ030380 Received: from mailsyshubprd06.lss.emc.com (mailsyshubprd06.lss.emc.com [10.253.24.24]) by maildlpprd04.lss.emc.com (RSA Interceptor); Wed, 20 May 2015 16:41:40 -0400 Received: from HY-R1012-SPA.usd.lab.emc.com.com (hy-r1012-spa.rtp.lab.emc.com [10.6.71.221]) by mailsyshubprd06.lss.emc.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.0) with ESMTP id t4KKfftv012675; Wed, 20 May 2015 16:41:49 -0400 From: Allen Hubbe To: linux-ntb@googlegroups.com Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Jon Mason , Dave Jiang , Allen Hubbe Subject: [PATCH 10/16] ntb_transport: don't advance rx on link down Date: Wed, 20 May 2015 11:41:11 -0400 Message-Id: <5613ceb692dd7a5973d0b8d3269cc50a5b0721ee.1432135632.git.Allen.Hubbe@emc.com> X-Mailer: git-send-email 2.4.0.rc0.44.g244209c.dirty In-Reply-To: References: In-Reply-To: References: X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd04.lss.emc.com Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On link down, don't advance RX index to the next entry. The next entry should never be valid after receiving the link down flag. Signed-off-by: Allen Hubbe --- drivers/ntb/ntb_transport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c index 8a6db1a..9b4e240 100644 --- a/drivers/ntb/ntb_transport.c +++ b/drivers/ntb/ntb_transport.c @@ -1211,8 +1211,7 @@ static int ntb_process_rxc(struct ntb_transport_qp *qp) dev_dbg(&qp->ndev->pdev->dev, "link down flag set\n"); ntb_qp_link_down(qp); hdr->flags = 0; - iowrite32(qp->rx_index, &qp->rx_info->entry); - return 0; + return -EAGAIN; } if (hdr->ver != (u32)qp->rx_pkts) {