From patchwork Sun Sep 20 16:11:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Knuth Posern X-Patchwork-Id: 520004 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2982C1401CD for ; Mon, 21 Sep 2015 02:20:28 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753479AbbITQU0 (ORCPT ); Sun, 20 Sep 2015 12:20:26 -0400 Received: from mx01.mykolab.com ([95.128.36.1]:14994 "EHLO mx-out02.mykolab.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753410AbbITQUZ (ORCPT ); Sun, 20 Sep 2015 12:20:25 -0400 X-Greylist: delayed 525 seconds by postgrey-1.27 at vger.kernel.org; Sun, 20 Sep 2015 12:20:25 EDT X-Virus-Scanned: amavisd-new at kolabnow.com X-Spam-Flag: NO X-Spam-Score: -2.183 X-Spam-Level: X-Spam-Status: No, score=-2.183 tagged_above=-10 required=6.31 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, MIME_HEADER_CTYPE_ONLY=0.717] autolearn=no Received: from mx03.mykolab.com (mx03.mykolab.com [10.20.7.101]) by mx-out02.mykolab.com (Postfix) with ESMTPS id 4062C6148B; Sun, 20 Sep 2015 18:11:36 +0200 (CEST) From: Knuth Posern Subject: [PATCH] Thunderbolt 2 driver for recent Apple MacBooks To: linux-kernel@vger.kernel.org Cc: Andreas Noever , Greg KH , linux-pci@vger.kernel.org Message-ID: <55FEDAAD.6000804@posern.org> Date: Sun, 20 Sep 2015 18:11:25 +0200 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, This patch is submitted for upstream inclusion. This is a first for me, so I hope the format of this mail is convenient. Thanks to Greg and Andreas the attached patch (diff -up) fixes the bug: https://bugzilla.kernel.org/show_bug.cgi?id=100191 The pci device ids listed in the tb driver are to restrictive, which prevents the driver from being loaded. We have had a similar issue with the new Mac mini. Changing the subvendor and subdevice to PCI_ANY_ID in drivers/thunderbolt/nhi.c the thunderbolt driver loads and binds to the pci device 07:00.0 System peripheral: Intel Corporation Device 156c which is the thunderbolt 2 controller. Cheers, Knuth. --- linux/drivers/thunderbolt/nhi.c.orig 2015-09-20 17:36:14.014964300 +0200 +++ linux/drivers/thunderbolt/nhi.c 2015-09-13 09:58:18.000000000 +0200 @@ -643,7 +643,7 @@ static struct pci_device_id nhi_ids[] = { .class = PCI_CLASS_SYSTEM_OTHER << 8, .class_mask = ~0, .vendor = PCI_VENDOR_ID_INTEL, .device = 0x156c, - .subvendor = 0x2222, .subdevice = 0x1111, + .subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, }, { 0,} };