From patchwork Fri Aug 18 07:26:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: sparkhuang X-Patchwork-Id: 1822728 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2620:137:e000::1:20; helo=out1.vger.email; envelope-from=linux-pci-owner@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by legolas.ozlabs.org (Postfix) with ESMTP id 4RRtlt2JlSz1ygH for ; Fri, 18 Aug 2023 17:28:58 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358198AbjHRH21 (ORCPT ); Fri, 18 Aug 2023 03:28:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358229AbjHRH1r (ORCPT ); Fri, 18 Aug 2023 03:27:47 -0400 X-Greylist: delayed 63 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 18 Aug 2023 00:27:43 PDT Received: from outboundhk.mxmail.xiaomi.com (outboundhk.mxmail.xiaomi.com [207.226.244.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B833D30F1; Fri, 18 Aug 2023 00:27:43 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.01,182,1684771200"; d="scan'208";a="87750283" From: =?eucgb2312_cn?b?u8bJ2bKo?= To: Bjorn Helgaas , Thomas Gleixner , "Ahmed S. Darwish" , Jason Gunthorpe , Kevin Tian , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: =?eucgb2312_cn?b?wO6438X0?= , =?eucgb2312_cn?b?wbrOsMX0?= , =?eucgb2312_cn?b?zsy98LfJ?= , =?eucgb2312_cn?b?0NzBwQ==?= Subject: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc Thread-Topic: Subject: [PATCH] pci/msi: remove redundant calculation in msi_setup_msi_desc Thread-Index: AdnRpKW3tDXXI46aR/+qEejYHxfxLQ== Date: Fri, 18 Aug 2023 07:26:38 +0000 Message-ID: <3ebf5d8032ad418da4f24516cd23406e@xiaomi.com> Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.237.8.11] MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Whether to support 64-bit address status has been calculated before, and the calculation result can be used directly afterwards, so use msi_attrib.is_64 to avoid double calculation. Suggested-by: weipengliang Signed-off-by: sparkhuang Reviewed-by: Ilpo Järvinen --- drivers/pci/msi/msi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 #/******本邮件及其附件含有小米公司的保密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本邮件！ This e-mail and its attachments contain confidential information from XIAOMI, which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction, or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender by phone or email immediately and delete it!******/# diff --git a/drivers/pci/msi/msi.c b/drivers/pci/msi/msi.c index ef1d885..304e889 100644 --- a/drivers/pci/msi/msi.c +++ b/drivers/pci/msi/msi.c @@ -303,7 +303,7 @@ static int msi_setup_msi_desc(struct pci_dev *dev, int nvec, desc.pci.msi_attrib.multiple = ilog2(__roundup_pow_of_two(nvec)); desc.affinity = masks; - if (control & PCI_MSI_FLAGS_64BIT) + if (desc.pci.msi_attrib.is_64) desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_64; else desc.pci.mask_pos = dev->msi_cap + PCI_MSI_MASK_32;