From patchwork Wed Apr 3 21:38:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 1919434 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=Y2Ej//Hu; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=2604:1380:45e3:2400::1; helo=sv.mirrors.kernel.org; envelope-from=linux-pci+bounces-5639-incoming=patchwork.ozlabs.org@vger.kernel.org; receiver=patchwork.ozlabs.org) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org [IPv6:2604:1380:45e3:2400::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V8ynb2TwBz1yYn for ; Thu, 4 Apr 2024 08:39:31 +1100 (AEDT) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B0ABD28B247 for ; Wed, 3 Apr 2024 21:39:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B84315689F; Wed, 3 Apr 2024 21:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Y2Ej//Hu" X-Original-To: linux-pci@vger.kernel.org Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB55E156258 for ; Wed, 3 Apr 2024 21:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712180352; cv=none; b=Mtw5X5vALEyKYBdN5PI1TjWtCitTlUI0umjSra9DzqNvQTqHZF/T7rgXXwr2LisT5nV1oX7YNz5rQSI8D371fxl7+93agiwO3fsAaC9kSl0nECg7YPbwW9xDWuqAZDqPcm65a/WR4vud22aqvhqzHu3NoimjH44vUJauIiPyApM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712180352; c=relaxed/simple; bh=KTDIIL3thwGB0XafQjEUjEVXdcuQs+8Wg8MnA1TQ9t4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type; b=WK0yrZ1uevfTXH4qj6LfbT1zG9vN6l9Qe0BHfnGjuEDsTM0hLXTnPdIdUQmxJTvp4RSuc1kVJQKPS7pWTl4HGcl877PCj+u/3/BWwq6RwhklCVwhuziO4PgvXepwkcv5AM/3B+4BCHHs22iJbWJo3LKrcwTdeXX5JxV1C/0TkI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Y2Ej//Hu; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-690be110d0dso1278836d6.3 for ; Wed, 03 Apr 2024 14:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1712180349; x=1712785149; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=joMNarD8mXKll+1LziloVXp7WpxnXBH+JlOIdpmTpGw=; b=Y2Ej//HuTalANam0eghssZwH63BfenEbgw+Ba/50bg9OGZ8qhADyCS/zx1EvA8S/XO hSZfptdD89ypD+4voKe0XrF48BUv3bJoV0BNCYWh0AfseLDiks55f2PCqXehCznWTWnb ZaL9vrCpPYkelSqtuTohHoO9HdYVN2S5pYL+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712180349; x=1712785149; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=joMNarD8mXKll+1LziloVXp7WpxnXBH+JlOIdpmTpGw=; b=pff2z8uS2KFYwu97nVGe8JdzxHVDGbwoA5grFtkWoikMajVslwm8dAylHwQvF4YKUL O6WS2/zBWfldJK1bK85lTxWZ7CoIrIF8/JQKsomtPEeYOMHAYItoxdw5nH/zHIZrZaDG mMvIHgIUu3yP5UG/D8fFvv6sZ/gdqYa4VH2Ir8v/0Vy+z9Wo90XBDWSgMRRiTxfmiQXj svXdKsd7Qa1ARuBu116RzYJtRCvC3OPaRQoMfGSEsI6s2LC2Yu5dp8YYuD4tt0ySUsLm 1oBvQZwZMLauGfuY9rWMrYxJKt9/tRRfXDX/qzFYnucEs2Eqvnq+hE37bQB/wMiMb0j7 lfZQ== X-Gm-Message-State: AOJu0Yyc7YXwxX6mc4D0hGdHYHMLlv7vVbqdaM3CFb9ONYZklP4uLwjY 9sEQ6Whc/8uC2VPUtLfNCwDvT7M+X53xjmruC9CyssSXiWXiPacftNnmP4Me/wTMiUj957uvQac +dsqPPe3rJX63jkSgMbC0ClEQv+vuVzmFcWN7ot+3hOnSp42SmxOc7jibrgjBtbsOp3kxIana47 qnABZ0aKox+TmfwsHuEsW6Nvz7jtkgRYsb6GDC30Yf8cbDfA== X-Google-Smtp-Source: AGHT+IGlR1uW9LzpHr+wnIKA1zbBfeqbFshXzeFwm8pcv2wiLPbzzMpB8p5PBY53bhBMCO3KfvaNtA== X-Received: by 2002:a05:6214:258b:b0:699:163c:a44c with SMTP id fq11-20020a056214258b00b00699163ca44cmr706072qvb.1.1712180348684; Wed, 03 Apr 2024 14:39:08 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id pi10-20020a0562144a8a00b0069903cddc96sm1750739qvb.18.2024.04.03.14.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 14:39:07 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Jim Quinlan , Florian Fainelli , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v9 1/4] dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" Date: Wed, 3 Apr 2024 17:38:58 -0400 Message-Id: <20240403213902.26391-2-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240403213902.26391-1-james.quinlan@broadcom.com> References: <20240403213902.26391-1-james.quinlan@broadcom.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOCs -- requires the driver to deliberately place the RC HW one of three CLKREQ# modes. The "brcm,clkreq-mode" property allows the user to override the default setting. If this property is omitted, the default mode shall be "default". Signed-off-by: Jim Quinlan Acked-by: Conor Dooley Reviewed-by: Rob Herring --- .../devicetree/bindings/pci/brcm,stb-pcie.yaml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml index 7e15aae7d69e..22491f7f8852 100644 --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml @@ -64,6 +64,24 @@ properties: aspm-no-l0s: true + brcm,clkreq-mode: + description: A string that determines the operating + clkreq mode of the PCIe RC HW with respect to controlling the refclk + signal. There are three different modes -- "safe", which drives the + refclk signal unconditionally and will work for all devices but does + not provide any power savings; "no-l1ss" -- which provides Clock + Power Management, L0s, and L1, but cannot provide L1 substate (L1SS) + power savings. If the downstream device connected to the RC is L1SS + capable AND the OS enables L1SS, all PCIe traffic may abruptly halt, + potentially hanging the system; "default" -- which provides L0s, L1, + and L1SS, but not compliant to provide Clock Power Management; + specifically, may not be able to meet the T_CLRon max timing of 400ns + as specified in "Dynamic Clock Control", section 3.2.5.2.2 PCI + Express Mini CEM 2.1 specification. This situation is atypical and + should happen only with older devices. + $ref: /schemas/types.yaml#/definitions/string + enum: [ safe, no-l1ss, default ] + brcm,scb-sizes: description: u64 giving the 64bit PCIe memory viewport size of a memory controller. There may be up to