diff mbox series

PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports

Message ID 20240305113057.56468-1-pmenzel@molgen.mpg.de
State New
Headers show
Series PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports | expand

Commit Message

Paul Menzel March 5, 2024, 11:30 a.m. UTC 
Commit 5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root
Ports") and commit 3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice
Lake Root Ports") add quirks for Ice, Tiger and Alder Lake Root Ports.
System firmware for Raptor Lake still has the bug, so Linux logs the
warning below on several Raptor Lake systems like Dell Precision 3581 with
Intel Raptor Lake processor (0W18NX) system firmware/BIOS version 1.10.1.

    pci 0000:00:07.0: [8086:a76e] type 01 class 0x060400
    pci 0000:00:07.0: PME# supported from D0 D3hot D3cold
    pci 0000:00:07.0: PTM enabled (root), 4ns granularity
    pci 0000:00:07.0: DPC: RP PIO log size 0 is invalid
    pci 0000:00:07.1: [8086:a73f] type 01 class 0x060400
    pci 0000:00:07.1: PME# supported from D0 D3hot D3cold
    pci 0000:00:07.1: PTM enabled (root), 4ns granularity
    pci 0000:00:07.1: DPC: RP PIO log size 0 is invalid

So, apply the quirk for Raptor Lake Root Ports as well.

This also enables the DPC driver to dump the RP PIO Log registers when DPC
is triggered.

Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218560
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: nvaert1986@hotmail.com
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 drivers/pci/quirks.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bjorn Helgaas March 5, 2024, 6:23 p.m. UTC | #1 
On Tue, Mar 05, 2024 at 12:30:56PM +0100, Paul Menzel wrote:
> Commit 5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root
> Ports") and commit 3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice
> Lake Root Ports") add quirks for Ice, Tiger and Alder Lake Root Ports.
> System firmware for Raptor Lake still has the bug, so Linux logs the
> warning below on several Raptor Lake systems like Dell Precision 3581 with
> Intel Raptor Lake processor (0W18NX) system firmware/BIOS version 1.10.1.
> 
>     pci 0000:00:07.0: [8086:a76e] type 01 class 0x060400
>     pci 0000:00:07.0: PME# supported from D0 D3hot D3cold
>     pci 0000:00:07.0: PTM enabled (root), 4ns granularity
>     pci 0000:00:07.0: DPC: RP PIO log size 0 is invalid
>     pci 0000:00:07.1: [8086:a73f] type 01 class 0x060400
>     pci 0000:00:07.1: PME# supported from D0 D3hot D3cold
>     pci 0000:00:07.1: PTM enabled (root), 4ns granularity
>     pci 0000:00:07.1: DPC: RP PIO log size 0 is invalid
> 
> So, apply the quirk for Raptor Lake Root Ports as well.
> 
> This also enables the DPC driver to dump the RP PIO Log registers when DPC
> is triggered.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218560
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: nvaert1986@hotmail.com
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Added stable tag and applied to pci/dpc for v6.9 with tags:

  Reported-by: <nvaert1986@hotmail.com>
  Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218560
  Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
  Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  Cc: <stable@vger.kernel.org>
  Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
  Cc: <nvaert1986@hotmail.com>

nvaert1986@, thanks very much for your report.  Let me know if you
prefer to omit your email or add your real name.  Happy to do either.

> ---
>  drivers/pci/quirks.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index d797df6e5f3e..663d838fa861 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -6225,6 +6225,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2b, dpc_log_size);
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2d, dpc_log_size);
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2f, dpc_log_size);
>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a31, dpc_log_size);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa73f, dpc_log_size);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
>  #endif
>  
>  /*
> -- 
> 2.43.0
>
Bjorn Helgaas March 5, 2024, 6:32 p.m. UTC | #2 
On Tue, Mar 5, 2024 at 12:28 PM Niels van Aert <nvaert1986@hotmail.com> wrote:
>
> Bjorn,
>
> Feel free to add my name Niels van Aert and e-mail address.

Done, thanks very much!

> ________________________________
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Tuesday, March 5, 2024 7:23 PM
> To: Paul Menzel <pmenzel@molgen.mpg.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>; Mika Westerberg <mika.westerberg@linux.intel.com>; nvaert1986@hotmail.com <nvaert1986@hotmail.com>; linux-pci@vger.kernel.org <linux-pci@vger.kernel.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] PCI/DPC: Quirk PIO log size for Intel Raptor Lake Root Ports
>
> On Tue, Mar 05, 2024 at 12:30:56PM +0100, Paul Menzel wrote:
> > Commit 5459c0b70467 ("PCI/DPC: Quirk PIO log size for certain Intel Root
> > Ports") and commit 3b8803494a06 ("PCI/DPC: Quirk PIO log size for Intel Ice
> > Lake Root Ports") add quirks for Ice, Tiger and Alder Lake Root Ports.
> > System firmware for Raptor Lake still has the bug, so Linux logs the
> > warning below on several Raptor Lake systems like Dell Precision 3581 with
> > Intel Raptor Lake processor (0W18NX) system firmware/BIOS version 1.10.1.
> >
> >     pci 0000:00:07.0: [8086:a76e] type 01 class 0x060400
> >     pci 0000:00:07.0: PME# supported from D0 D3hot D3cold
> >     pci 0000:00:07.0: PTM enabled (root), 4ns granularity
> >     pci 0000:00:07.0: DPC: RP PIO log size 0 is invalid
> >     pci 0000:00:07.1: [8086:a73f] type 01 class 0x060400
> >     pci 0000:00:07.1: PME# supported from D0 D3hot D3cold
> >     pci 0000:00:07.1: PTM enabled (root), 4ns granularity
> >     pci 0000:00:07.1: DPC: RP PIO log size 0 is invalid
> >
> > So, apply the quirk for Raptor Lake Root Ports as well.
> >
> > This also enables the DPC driver to dump the RP PIO Log registers when DPC
> > is triggered.
> >
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218560
> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> > Cc: nvaert1986@hotmail.com
> > Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>
> Added stable tag and applied to pci/dpc for v6.9 with tags:
>
>   Reported-by: <nvaert1986@hotmail.com>
>   Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218560
>   Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
>   Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>   Cc: <stable@vger.kernel.org>
>   Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
>   Cc: <nvaert1986@hotmail.com>
>
> nvaert1986@, thanks very much for your report.  Let me know if you
> prefer to omit your email or add your real name.  Happy to do either.
>
> > ---
> >  drivers/pci/quirks.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > index d797df6e5f3e..663d838fa861 100644
> > --- a/drivers/pci/quirks.c
> > +++ b/drivers/pci/quirks.c
> > @@ -6225,6 +6225,8 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2b, dpc_log_size);
> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2d, dpc_log_size);
> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2f, dpc_log_size);
> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a31, dpc_log_size);
> > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa73f, dpc_log_size);
> > +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
> >  #endif
> >
> >  /*
> > --
> > 2.43.0
> >
diff mbox series

Patch

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index d797df6e5f3e..663d838fa861 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -6225,6 +6225,8 @@  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2b, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2d, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a2f, dpc_log_size);
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0x9a31, dpc_log_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa73f, dpc_log_size);
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL, 0xa76e, dpc_log_size);
 #endif
 
 /*