diff mbox series

[v1] PCI: Increase maximum PCIe physical function number to 7 for non-ARI devices

Message ID 20240216172449.8052-1-beanhuo@iokpp.de
State New
Headers show
Series [v1] PCI: Increase maximum PCIe physical function number to 7 for non-ARI devices | expand

Commit Message

Bean Huo Feb. 16, 2024, 5:24 p.m. UTC 
From: Bean Huo <beanhuo@micron.com>

The PCIe specification allows up to 8 Physical Functions (PFs) per endpoint
when ARI (Alternative Routing-ID Interpretation) is not supported. Previously,
our implementation erroneously limited the maximum number of PFs to 7 for
endpoints without ARI support.

This patch corrects the maximum PF count to adhere to the PCIe specification
by allowing up to 8 PFs on non-ARI endpoints. This change ensures better
compliance with the standard and improves compatibility with devices relying
on this specification.

This adjustment was verified against the PCIe spec (reference specific
sections if applicable) and tested with a range of PCIe devices not supporting
ARI to ensure no regressions in functionality.

Signed-off-by: Bean Huo <beanhuo@micron.com>
---
 drivers/pci/probe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kuppuswamy Sathyanarayanan Feb. 16, 2024, 5:53 p.m. UTC | #1 
On 2/16/24 9:24 AM, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
>
> The PCIe specification allows up to 8 Physical Functions (PFs) per endpoint
> when ARI (Alternative Routing-ID Interpretation) is not supported. Previously,
> our implementation erroneously limited the maximum number of PFs to 7 for
> endpoints without ARI support.
Can you include the spec section and revision details?

I assume it is section "Alternative Routing-ID Interpretation"
>
> This patch corrects the maximum PF count to adhere to the PCIe specification
> by allowing up to 8 PFs on non-ARI endpoints. This change ensures better
> compliance with the standard and improves compatibility with devices relying
> on this specification.
>
> This adjustment was verified against the PCIe spec (reference specific
> sections if applicable) and tested with a range of PCIe devices not supporting
> ARI to ensure no regressions in functionality.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---

Since it is a bug fix, I think you need a Fixes: tag as well.

>  drivers/pci/probe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index ed6b7f48736a..8c3d0f63bc13 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -2630,7 +2630,8 @@ static int next_fn(struct pci_bus *bus, struct pci_dev *dev, int fn)
>  	if (pci_ari_enabled(bus))
>  		return next_ari_fn(bus, dev, fn);
>  
> -	if (fn >= 7)
> +	/* If EP does not support ARI, the maximum number of functions should be 7 */
> +	if (fn > 7)
>  		return -ENODEV;
>  	/* only multifunction devices may have more functions */
>  	if (dev && !dev->multifunction)
diff mbox series

Patch

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index ed6b7f48736a..8c3d0f63bc13 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -2630,7 +2630,8 @@  static int next_fn(struct pci_bus *bus, struct pci_dev *dev, int fn)
 	if (pci_ari_enabled(bus))
 		return next_ari_fn(bus, dev, fn);
 
-	if (fn >= 7)
+	/* If EP does not support ARI, the maximum number of functions should be 7 */
+	if (fn > 7)
 		return -ENODEV;
 	/* only multifunction devices may have more functions */
 	if (dev && !dev->multifunction)