| Message ID | 20240112-opp_support-v6-1-77bbf7d0cc37@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: qcom: Add support for OPP | expand |
On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > Add the interconnects path as required property for sm8450 platform. There's no explaination here as to why you need two different compatibles for the instances on this device. Please add one. Thanks, Conor. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index eadba38171e1..bc28669f6fa0 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -777,6 +777,8 @@ allOf: > - qcom,pcie-sa8540p > - qcom,pcie-sa8775p > - qcom,pcie-sc8280xp > + - qcom,pcie-sm8450-pcie0 > + - qcom,pcie-sm8450-pcie1 > then: > required: > - interconnects > > -- > 2.42.0 >
On Fri, 12 Jan 2024 at 18:55, Conor Dooley <conor@kernel.org> wrote: > > On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > > Add the interconnects path as required property for sm8450 platform. > > There's no explaination here as to why you need two different > compatibles for the instances on this device. Please add one. Note, these are not new compatible strings. They are already defined (separate because port0 and port1 have different sets of NoC clocks). > > Thanks, > Conor. > > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > --- > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index eadba38171e1..bc28669f6fa0 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -777,6 +777,8 @@ allOf: > > - qcom,pcie-sa8540p > > - qcom,pcie-sa8775p > > - qcom,pcie-sc8280xp > > + - qcom,pcie-sm8450-pcie0 > > + - qcom,pcie-sm8450-pcie1 > > then: > > required: > > - interconnects > > > > -- > > 2.42.0 > >
On Fri, Jan 12, 2024 at 07:12:01PM +0200, Dmitry Baryshkov wrote: > On Fri, 12 Jan 2024 at 18:55, Conor Dooley <conor@kernel.org> wrote: > > > > On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > > > Add the interconnects path as required property for sm8450 platform. > > > > There's no explaination here as to why you need two different > > compatibles for the instances on this device. Please add one. > > Note, these are not new compatible strings. They are already defined > (separate because port0 and port1 have different sets of NoC clocks). Ahh, my bad. My comment can be disregarded. :wq > > > > > Thanks, > > Conor. > > > > > > > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > > > --- > > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > index eadba38171e1..bc28669f6fa0 100644 > > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > > @@ -777,6 +777,8 @@ allOf: > > > - qcom,pcie-sa8540p > > > - qcom,pcie-sa8775p > > > - qcom,pcie-sc8280xp > > > + - qcom,pcie-sm8450-pcie0 > > > + - qcom,pcie-sm8450-pcie1 > > > then: > > > required: > > > - interconnects > > > > > > -- > > > 2.42.0 > > > > > > > -- > With best wishes > Dmitry
On Fri, 12 Jan 2024 19:52:00 +0530, Krishna chaitanya chundru wrote: > Add the interconnects path as required property for sm8450 platform. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Fri, Jan 12, 2024 at 07:52:00PM +0530, Krishna chaitanya chundru wrote: > Add the interconnects path as required property for sm8450 platform. > > Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index eadba38171e1..bc28669f6fa0 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -777,6 +777,8 @@ allOf: > - qcom,pcie-sa8540p > - qcom,pcie-sa8775p > - qcom,pcie-sc8280xp > + - qcom,pcie-sm8450-pcie0 > + - qcom,pcie-sm8450-pcie1 > then: > required: > - interconnects > > -- > 2.42.0 >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index eadba38171e1..bc28669f6fa0 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -777,6 +777,8 @@ allOf: - qcom,pcie-sa8540p - qcom,pcie-sa8775p - qcom,pcie-sc8280xp + - qcom,pcie-sm8450-pcie0 + - qcom,pcie-sm8450-pcie1 then: required: - interconnects
Add the interconnects path as required property for sm8450 platform. Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ 1 file changed, 2 insertions(+)