| Message ID | 20231126071420.4207-1-jundongsong1@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI/RTR: Add RTR capability structure register definitions | expand |
On Sun, Nov 26, 2023 at 03:14:20PM +0800, Harry Song wrote: > Add RTR(Readiness Time Reporting) capability structure register > definitions for use in subsequent patches. > See the PCIe r3.1 spec, sec 7.35. Are the other patches coming later? It would make sense to add this as the first patch with a series if possible. > > Signed-off-by: Harry Song <jundongsong1@gmail.com> > --- > include/uapi/linux/pci_regs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 85ab12788..47db4915b 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -734,6 +734,7 @@ > #define PCI_EXT_CAP_ID_DPC 0x1D /* Downstream Port Containment */ > #define PCI_EXT_CAP_ID_L1SS 0x1E /* L1 PM Substates */ > #define PCI_EXT_CAP_ID_PTM 0x1F /* Precision Time Measurement */ > +#define PCI_EXT_CAP_ID_RTR 0x22 /* Readiness Time Reporting */ > #define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific */ > #define PCI_EXT_CAP_ID_DLF 0x25 /* Data Link Feature */ > #define PCI_EXT_CAP_ID_PL_16GT 0x26 /* Physical Layer 16.0 GT/s */ > @@ -1065,6 +1066,14 @@ > #define PCI_PTM_CTRL_ENABLE 0x00000001 /* PTM enable */ > #define PCI_PTM_CTRL_ROOT 0x00000002 /* Root select */ > > +/* Readiness Time Reporting */ > +#define PCI_RTR_CAP 0x04 /* RTR Capability */ > +#define PCI_RTR_RST_TIME_MASK 0xFFF /* RTR Reset Time Mask */ > +#define PCI_RTR_DLUP_TIME_MASK 0xFFF000 /* RTR Downstream Link UP Time Mask */ > +#define PCI_RTR_CAP2 0x08 /* RTR Capability 2 */ RTR_CAP and RTR_CAP2 seems odd. Can you call it RTR_CAP1 and RTR_CAP2 instead? Did you leave out the bit31 indicating the fields are valid? > +#define PCI_RTR_FLR_TIME_MASK 0xFFF /* RTR Function Level Reset Time Mask */ > +#define PCI_RTR_D3_TO_D0_TIME_MASK 0xFFF000 /* RTR D3-hot To D0 Time Mask */ Should ^^ be aligned to previous line? > + > /* ASPM L1 PM Substates */ > #define PCI_L1SS_CAP 0x04 /* Capabilities Register */ > #define PCI_L1SS_CAP_PCIPM_L1_2 0x00000001 /* PCI-PM L1.2 Supported */ > -- > 2.17.1 >
On Sun, Nov 26, 2023 at 03:14:20PM +0800, Harry Song wrote: > Add RTR(Readiness Time Reporting) capability structure register > definitions for use in subsequent patches. > See the PCIe r3.1 spec, sec 7.35. Please use the current spec revision, e.g., r6.0 or r6.1. Deferring this for now; please include it in the same series as the subsequent patches that use these definitions. Thanks for working on this! > Signed-off-by: Harry Song <jundongsong1@gmail.com> > --- > include/uapi/linux/pci_regs.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h > index 85ab12788..47db4915b 100644 > --- a/include/uapi/linux/pci_regs.h > +++ b/include/uapi/linux/pci_regs.h > @@ -734,6 +734,7 @@ > #define PCI_EXT_CAP_ID_DPC 0x1D /* Downstream Port Containment */ > #define PCI_EXT_CAP_ID_L1SS 0x1E /* L1 PM Substates */ > #define PCI_EXT_CAP_ID_PTM 0x1F /* Precision Time Measurement */ > +#define PCI_EXT_CAP_ID_RTR 0x22 /* Readiness Time Reporting */ > #define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific */ > #define PCI_EXT_CAP_ID_DLF 0x25 /* Data Link Feature */ > #define PCI_EXT_CAP_ID_PL_16GT 0x26 /* Physical Layer 16.0 GT/s */ > @@ -1065,6 +1066,14 @@ > #define PCI_PTM_CTRL_ENABLE 0x00000001 /* PTM enable */ > #define PCI_PTM_CTRL_ROOT 0x00000002 /* Root select */ > > +/* Readiness Time Reporting */ > +#define PCI_RTR_CAP 0x04 /* RTR Capability */ > +#define PCI_RTR_RST_TIME_MASK 0xFFF /* RTR Reset Time Mask */ These register fields are not called "masks" in the spec; let's try to make them match the spec terminology. Add leading zeroes to these values so the constant matches the width of the register, as is done for other similar values in this file. > +#define PCI_RTR_DLUP_TIME_MASK 0xFFF000 /* RTR Downstream Link UP Time Mask */ > +#define PCI_RTR_CAP2 0x08 /* RTR Capability 2 */ PCI_RTR_CAP and PCI_RTR_CAP2 are called "Readiness Time Reporting 1 Register" and "Readiness Time Reporting 2 Register" in the spec, so calling them _CAP and "Capability" is confusing. > +#define PCI_RTR_FLR_TIME_MASK 0xFFF /* RTR Function Level Reset Time Mask */ > +#define PCI_RTR_D3_TO_D0_TIME_MASK 0xFFF000 /* RTR D3-hot To D0 Time Mask */ > + > /* ASPM L1 PM Substates */ > #define PCI_L1SS_CAP 0x04 /* Capabilities Register */ > #define PCI_L1SS_CAP_PCIPM_L1_2 0x00000001 /* PCI-PM L1.2 Supported */ > -- > 2.17.1 >
diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h index 85ab12788..47db4915b 100644 --- a/include/uapi/linux/pci_regs.h +++ b/include/uapi/linux/pci_regs.h @@ -734,6 +734,7 @@ #define PCI_EXT_CAP_ID_DPC 0x1D /* Downstream Port Containment */ #define PCI_EXT_CAP_ID_L1SS 0x1E /* L1 PM Substates */ #define PCI_EXT_CAP_ID_PTM 0x1F /* Precision Time Measurement */ +#define PCI_EXT_CAP_ID_RTR 0x22 /* Readiness Time Reporting */ #define PCI_EXT_CAP_ID_DVSEC 0x23 /* Designated Vendor-Specific */ #define PCI_EXT_CAP_ID_DLF 0x25 /* Data Link Feature */ #define PCI_EXT_CAP_ID_PL_16GT 0x26 /* Physical Layer 16.0 GT/s */ @@ -1065,6 +1066,14 @@ #define PCI_PTM_CTRL_ENABLE 0x00000001 /* PTM enable */ #define PCI_PTM_CTRL_ROOT 0x00000002 /* Root select */ +/* Readiness Time Reporting */ +#define PCI_RTR_CAP 0x04 /* RTR Capability */ +#define PCI_RTR_RST_TIME_MASK 0xFFF /* RTR Reset Time Mask */ +#define PCI_RTR_DLUP_TIME_MASK 0xFFF000 /* RTR Downstream Link UP Time Mask */ +#define PCI_RTR_CAP2 0x08 /* RTR Capability 2 */ +#define PCI_RTR_FLR_TIME_MASK 0xFFF /* RTR Function Level Reset Time Mask */ +#define PCI_RTR_D3_TO_D0_TIME_MASK 0xFFF000 /* RTR D3-hot To D0 Time Mask */ + /* ASPM L1 PM Substates */ #define PCI_L1SS_CAP 0x04 /* Capabilities Register */ #define PCI_L1SS_CAP_PCIPM_L1_2 0x00000001 /* PCI-PM L1.2 Supported */
Add RTR(Readiness Time Reporting) capability structure register definitions for use in subsequent patches. See the PCIe r3.1 spec, sec 7.35. Signed-off-by: Harry Song <jundongsong1@gmail.com> --- include/uapi/linux/pci_regs.h | 9 +++++++++ 1 file changed, 9 insertions(+)