| Message ID | 20230614155556.4095526-4-daire.mcnamara@microchip.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: microchip: Fixes and clean-ups | expand |
Hello Daire, On Wed, Jun 14, 2023 at 04:55:51PM +0100, daire.mcnamara@microchip.com wrote: > From: Daire McNamara <daire.mcnamara@microchip.com> > > Enable building this driver as a module. The expected use case is the > driver is built as a module, is installed when needed, and cannot be > removed once installed. > > The remove() callback is not implemented as removing a driver with > INTx and MSI interrupt handling is inherently unsafe. The relevant thing here is not that there is no .remove callback (which doesn't make the driver non-removable) but that the driver has .suppress_bind_attrs = true. With that properly mentioned in the changelog, the patch is fine for me. Best regards Uwe
Nit: "Enable building driver as a module" Capital "E" and removed "this" as that's obvious. On Wed, Jun 14, 2023 at 04:55:51PM +0100, daire.mcnamara@microchip.com wrote: > From: Daire McNamara <daire.mcnamara@microchip.com> > > Enable building this driver as a module. The expected use case is the > driver is built as a module, is installed when needed, and cannot be > removed once installed. > > The remove() callback is not implemented as removing a driver with > INTx and MSI interrupt handling is inherently unsafe. Other than Uwe's comment, that I will integrate, the sentence above should be linked to the Link: below otherwise it is not easy to parse - it requires some context. I will do it. Lorenzo > > Link: https://lore.kernel.org/linux-pci/87y1wgbah8.wl-maz@kernel.org/ > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com> > Acked-by: Conor Dooley <conor.dooley@microchip.com> > --- > drivers/pci/controller/Kconfig | 2 +- > drivers/pci/controller/pcie-microchip-host.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 8d49bad7f847..f4ad0e9cca45 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -217,7 +217,7 @@ config PCIE_MT7621 > This selects a driver for the MediaTek MT7621 PCIe Controller. > > config PCIE_MICROCHIP_HOST > - bool "Microchip AXI PCIe controller" > + tristate "Microchip AXI PCIe controller" > depends on PCI_MSI && OF > select PCI_HOST_COMMON > help > diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c > index 73046bad1521..5efd480e42fa 100644 > --- a/drivers/pci/controller/pcie-microchip-host.c > +++ b/drivers/pci/controller/pcie-microchip-host.c > @@ -1141,5 +1141,6 @@ static struct platform_driver mc_pcie_driver = { > }; > > builtin_platform_driver(mc_pcie_driver); > +MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("Microchip PCIe host controller driver"); > MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>"); > -- > 2.25.1 >
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index 8d49bad7f847..f4ad0e9cca45 100644 --- a/drivers/pci/controller/Kconfig +++ b/drivers/pci/controller/Kconfig @@ -217,7 +217,7 @@ config PCIE_MT7621 This selects a driver for the MediaTek MT7621 PCIe Controller. config PCIE_MICROCHIP_HOST - bool "Microchip AXI PCIe controller" + tristate "Microchip AXI PCIe controller" depends on PCI_MSI && OF select PCI_HOST_COMMON help diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c index 73046bad1521..5efd480e42fa 100644 --- a/drivers/pci/controller/pcie-microchip-host.c +++ b/drivers/pci/controller/pcie-microchip-host.c @@ -1141,5 +1141,6 @@ static struct platform_driver mc_pcie_driver = { }; builtin_platform_driver(mc_pcie_driver); +MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Microchip PCIe host controller driver"); MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");