diff mbox series

[05/20] x86: head: add dummy prototype for mk_early_pgtbl_32

Message ID 20230516193549.544673-6-arnd@kernel.org
State New
Headers show
Series x86: address -Wmissing-prototype warnings | expand

Commit Message

Arnd Bergmann May 16, 2023, 7:35 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

'make W=1' warns about a function without a prototype in the x86-32 head code:

arch/x86/kernel/head32.c:72:13: error: no previous prototype for 'mk_early_pgtbl_32' [-Werror=missing-prototypes]

This is called from assembler code, so it does not actually need a prototype.
I could not find an appropriate header for it, so just declare it in front
of the definition to shut up th warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/x86/kernel/head32.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Alexander Lobakin May 18, 2023, 4:52 p.m. UTC | #1 
From: Arnd Bergmann <arnd@kernel.org>
Date: Tue, 16 May 2023 21:35:34 +0200

> From: Arnd Bergmann <arnd@arndb.de>
> 
> 'make W=1' warns about a function without a prototype in the x86-32 head code:
> 
> arch/x86/kernel/head32.c:72:13: error: no previous prototype for 'mk_early_pgtbl_32' [-Werror=missing-prototypes]
> 
> This is called from assembler code, so it does not actually need a prototype.
> I could not find an appropriate header for it, so just declare it in front
> of the definition to shut up th warning.

                               ^^
                               the :p

> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

I'd say, for the whole series:

Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>

BUT apart from the Xen part, it's all black magic rituals to me :D

Thanks,
Olek
diff mbox series

Patch

diff --git a/arch/x86/kernel/head32.c b/arch/x86/kernel/head32.c
index 10c27b4261eb..246a609f889b 100644
--- a/arch/x86/kernel/head32.c
+++ b/arch/x86/kernel/head32.c
@@ -69,6 +69,7 @@  asmlinkage __visible void __init __noreturn i386_start_kernel(void)
  * to the first kernel PMD. Note the upper half of each PMD or PTE are
  * always zero at this stage.
  */
+void __init mk_early_pgtbl_32(void);
 void __init mk_early_pgtbl_32(void)
 {
 #ifdef __pa