| Message ID | 20230511190902.28896-6-Sergey.Semin@baikalelectronics.ru |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: dwc: Relatively simple fixes and cleanups | expand |
Hi Serge, > From: Serge Semin, Sent: Friday, May 12, 2023 4:09 AM > > Most likely by mistake the PORT_LINK_FAST_LINK_MODE flag unsetting was > added twice in the commit cff9244432e8 ("PCI: dwc: Ensure FAST_LINK_MODE > is cleared"): first it is cleared right after the content of the > PCIE_PORT_LINK_CONTROL register is read, second it's cleared in the > framework of the link-mode initialization procedure. The later action is > redundant. Let's drop it. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> I'm not sure whether my review is useful or not, but anyway, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda > --- > drivers/pci/controller/dwc/pcie-designware.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c > index 8e33e6e59e68..e55b7b387eb6 100644 > --- a/drivers/pci/controller/dwc/pcie-designware.c > +++ b/drivers/pci/controller/dwc/pcie-designware.c > @@ -1019,7 +1019,6 @@ void dw_pcie_setup(struct dw_pcie *pci) > } > > /* Set the number of lanes */ > - val &= ~PORT_LINK_FAST_LINK_MODE; > val &= ~PORT_LINK_MODE_MASK; > switch (pci->num_lanes) { > case 1: > -- > 2.40.0 >
diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index 8e33e6e59e68..e55b7b387eb6 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -1019,7 +1019,6 @@ void dw_pcie_setup(struct dw_pcie *pci) } /* Set the number of lanes */ - val &= ~PORT_LINK_FAST_LINK_MODE; val &= ~PORT_LINK_MODE_MASK; switch (pci->num_lanes) { case 1:
Most likely by mistake the PORT_LINK_FAST_LINK_MODE flag unsetting was added twice in the commit cff9244432e8 ("PCI: dwc: Ensure FAST_LINK_MODE is cleared"): first it is cleared right after the content of the PCIE_PORT_LINK_CONTROL register is read, second it's cleared in the framework of the link-mode initialization procedure. The later action is redundant. Let's drop it. Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- drivers/pci/controller/dwc/pcie-designware.c | 1 - 1 file changed, 1 deletion(-)