| Message ID | 20230214121333.1837-6-shradha.t@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | Refactor Exynos PCIe driver to make it generic | expand |
On Tue, 14 Feb 2023 17:43:22 +0530, Shradha Todi wrote: > DT uses the name elbi in reg-names for application logic > registers which is a wrong nomenclature. This patch fixes > the same. > > This commit shouldn't be applied without changes > "arm64: dts: Rename the term elbi to appl" and > "PCI: samsung: Rename the term elbi to appl" > > Signed-off-by: Shradha Todi <shradha.t@samsung.com> > --- > Documentation/devicetree/bindings/pci/samsung,pcie.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/samsung,pcie.example.dtb: pcie@15700000: reg-names:1: 'appl' was expected From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/samsung,pcie.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230214121333.1837-6-shradha.t@samsung.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Feb 14, 2023 at 05:43:22PM +0530, Shradha Todi wrote: > DT uses the name elbi in reg-names for application logic > registers which is a wrong nomenclature. This patch fixes > the same. > > This commit shouldn't be applied without changes > "arm64: dts: Rename the term elbi to appl" and > "PCI: samsung: Rename the term elbi to appl" Which is your clue that this is an ABI break. You're stuck with the old name unless the ABI break is fine for all Samsung platforms using this. Rob
On 14/02/2023 20:15, Rob Herring wrote: > On Tue, Feb 14, 2023 at 05:43:22PM +0530, Shradha Todi wrote: >> DT uses the name elbi in reg-names for application logic >> registers which is a wrong nomenclature. This patch fixes >> the same. >> >> This commit shouldn't be applied without changes >> "arm64: dts: Rename the term elbi to appl" and >> "PCI: samsung: Rename the term elbi to appl" > > Which is your clue that this is an ABI break. You're stuck with the old > name unless the ABI break is fine for all Samsung platforms using this. This piece is quite stable so even without many out-of-tree users, we shouldn't break it without valid reason. Wrong nomenclature is not necessarily valid enough. Best regards, Krzysztof
> -----Original Message----- > From: Rob Herring [mailto:robh@kernel.org] > Sent: 14 February 2023 21:43 > To: Shradha Todi <shradha.t@samsung.com> > Cc: alim.akhtar@samsung.com; Sergey.Semin@baikalelectronics.ru; > pankaj.dubey@samsung.com; jh80.chung@samsung.co; > krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; > lukas.bulwahn@gmail.com; hongxing.zhu@nxp.com; bhelgaas@google.com; > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > m.szyprowski@samsung.com; linux-kernel@vger.kernel.org; > lpieralisi@kernel.org; tglx@linutronix.de; linux-samsung- > soc@vger.kernel.org; kw@linux.com; jingoohan1@gmail.com > Subject: Re: [PATCH 05/16] dt-bindings: PCI: Rename the term elbi to appl > > > On Tue, 14 Feb 2023 17:43:22 +0530, Shradha Todi wrote: > > DT uses the name elbi in reg-names for application logic registers > > which is a wrong nomenclature. This patch fixes the same. > > > > This commit shouldn't be applied without changes > > "arm64: dts: Rename the term elbi to appl" and > > "PCI: samsung: Rename the term elbi to appl" > > > > Signed-off-by: Shradha Todi <shradha.t@samsung.com> > > --- > > Documentation/devicetree/bindings/pci/samsung,pcie.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/pci/samsung,pcie.example.dtb > : pcie@15700000: reg-names:1: 'appl' was expected > From schema: /builds/robherring/dt-review- > ci/linux/Documentation/devicetree/bindings/pci/samsung,pcie.yaml > > doc reference errors (make refcheckdocs): > > See https://protect2.fireeye.com/v1/url?k=b0812da3-d10a3895-b080a6ec- > 74fe485fffe0-cf137b875436d997&q=1&e=09e1c000-01c6-48c4-8fff- > 94e474b2862c&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev > icetree-bindings%2Fpatch%2F20230214121333.1837-6- > shradha.t%40samsung.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your > schema. Thanks for review. Sorry, I missed to update the example. Will take care in next patch set.
diff --git a/Documentation/devicetree/bindings/pci/samsung,pcie.yaml b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml index 6cd36d9ccba0..9c58c4d1f6a7 100644 --- a/Documentation/devicetree/bindings/pci/samsung,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/samsung,pcie.yaml @@ -25,13 +25,13 @@ properties: reg: items: - description: Data Bus Interface (DBI) registers. - - description: External Local Bus interface (ELBI) registers. + - description: Controller's application logic registers. - description: PCIe configuration space region. reg-names: items: - const: dbi - - const: elbi + - const: appl - const: config interrupts:
DT uses the name elbi in reg-names for application logic registers which is a wrong nomenclature. This patch fixes the same. This commit shouldn't be applied without changes "arm64: dts: Rename the term elbi to appl" and "PCI: samsung: Rename the term elbi to appl" Signed-off-by: Shradha Todi <shradha.t@samsung.com> --- Documentation/devicetree/bindings/pci/samsung,pcie.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)