| Message ID | 20221114012036.2870067-1-git@johnthomson.fastmail.com.au |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] PCI: mt7621: add sentinel to quirks table | expand |
Hi John, On Mon, Nov 14, 2022 at 2:20 AM John Thomson <git@johnthomson.fastmail.com.au> wrote: > > With mt7621 soc_dev_attr fixed to register the soc as a device, > kernel will experience an oops in soc_device_match_attr > > This quirk test was introduced in the staging driver in > commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > using 'soc_device_attribute'"), and the staging driver was moved in > commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host > controller driver") for the 5.16 kernel > > Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@app.fastmail.com > Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'") > Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au> > --- > v1 Link: https://lore.kernel.org/lkml/20221104205242.3440388-3-git@johnthomson.fastmail.com.au/#t > v2: no newline in middle of Fixes tag > --- > drivers/pci/controller/pcie-mt7621.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I am pretty sure I already gave my Acked-by in the previous version of this patch. You should add tags when you submit new versiones. Anyway: Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Thanks, Sergio Paracuellos
On Mon, Nov 14, 2022 at 7:05 AM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > > Hi John, > > On Mon, Nov 14, 2022 at 2:20 AM John Thomson > <git@johnthomson.fastmail.com.au> wrote: > > > > With mt7621 soc_dev_attr fixed to register the soc as a device, > > kernel will experience an oops in soc_device_match_attr > > > > This quirk test was introduced in the staging driver in > > commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision > > using 'soc_device_attribute'"), and the staging driver was moved in > > commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host > > controller driver") for the 5.16 kernel > > > > Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@app.fastmail.com > > Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'") > > Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au> > > --- > > v1 Link: https://lore.kernel.org/lkml/20221104205242.3440388-3-git@johnthomson.fastmail.com.au/#t > > v2: no newline in middle of Fixes tag > > --- > > drivers/pci/controller/pcie-mt7621.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > I am pretty sure I already gave my Acked-by in the previous version of > this patch. You should add tags when you submit new versiones. Anyway: > > Acked-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > Thanks, > Sergio Paracuellos Gentle ping for this patch :) Thanks, Sergio Paracuellos
diff --git a/drivers/pci/controller/pcie-mt7621.c b/drivers/pci/controller/pcie-mt7621.c index 4bd1abf26008..ee7aad09d627 100644 --- a/drivers/pci/controller/pcie-mt7621.c +++ b/drivers/pci/controller/pcie-mt7621.c @@ -466,7 +466,8 @@ static int mt7621_pcie_register_host(struct pci_host_bridge *host) } static const struct soc_device_attribute mt7621_pcie_quirks_match[] = { - { .soc_id = "mt7621", .revision = "E2" } + { .soc_id = "mt7621", .revision = "E2" }, + { /* sentinel */ } }; static int mt7621_pcie_probe(struct platform_device *pdev)
With mt7621 soc_dev_attr fixed to register the soc as a device, kernel will experience an oops in soc_device_match_attr This quirk test was introduced in the staging driver in commit b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'"), and the staging driver was moved in commit 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver") for the 5.16 kernel Link: https://lore.kernel.org/lkml/26ebbed1-0fe9-4af9-8466-65f841d0b382@app.fastmail.com Fixes: b483b4e4d3f6 ("staging: mt7621-pci: add quirks for 'E2' revision using 'soc_device_attribute'") Signed-off-by: John Thomson <git@johnthomson.fastmail.com.au> --- v1 Link: https://lore.kernel.org/lkml/20221104205242.3440388-3-git@johnthomson.fastmail.com.au/#t v2: no newline in middle of Fixes tag --- drivers/pci/controller/pcie-mt7621.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)