| Message ID | 20220805105238.345599-1-shijie@os.amperecomputing.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] PCI: update the links for aer-inject git tree | expand |
On 8/5/22 17:52, Huang Shijie wrote: > The aer-inject tree has been moved to: > https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git > Update the links. > > Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com> > --- > v1 --> v2: Modified the commit message and the title. > v2 --> v3: Change the commit message again. > --- The change log could have been before the diffstat below (so it won't be displayed on git log when applied). > Documentation/PCI/pcieaer-howto.rst | 2 +- > drivers/pci/pcie/Kconfig | 2 +- > drivers/pci/pcie/aer_inject.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/PCI/pcieaer-howto.rst b/Documentation/PCI/pcieaer-howto.rst > index 0b36b9ebfa4b..b31fc9a0edbc 100644 > --- a/Documentation/PCI/pcieaer-howto.rst > +++ b/Documentation/PCI/pcieaer-howto.rst > @@ -294,7 +294,7 @@ After reboot with new kernel or insert the module, a device file named > Then, you need a user space tool named aer-inject, which can be gotten > from: > > - https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ > + https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ > > More information about aer-inject can be found in the document comes > with its source code. > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index 788ac8df3f9d..d6ea0fd9892d 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -43,7 +43,7 @@ config PCIEAER_INJECT > error injection can fake almost all kinds of errors with the > help of a user space helper tool aer-inject, which can be > gotten from: > - https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ > + https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ > > # > # PCI Express ECRC > diff --git a/drivers/pci/pcie/aer_inject.c b/drivers/pci/pcie/aer_inject.c > index 2dab275d252f..262b06b0dc1d 100644 > --- a/drivers/pci/pcie/aer_inject.c > +++ b/drivers/pci/pcie/aer_inject.c > @@ -6,7 +6,7 @@ > * trigger various real hardware errors. Software based error > * injection can fake almost all kinds of errors with the help of a > * user space helper tool aer-inject, which can be gotten from: > - * https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ > + * https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ > * > * Copyright 2009 Intel Corporation. > * Huang Ying <ying.huang@intel.com> Otherwise looks OK. Reviewed-by: Bagas Sanjaya <bagasdotme@gmail.com>
Fri, 5 Aug 2022 20:31:33 +0700, Bagas Sanjaya wrote: > On 8/5/22 17:52, Huang Shijie wrote: >> The aer-inject tree has been moved to: >> https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git >> Update the links. >> >> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com> >> --- >> v1 --> v2: Modified the commit message and the title. >> v2 --> v3: Change the commit message again. >> --- > > The change log could have been before the diffstat below (so it won't be > displayed on git log when applied). Are you sure Bagas? :-) >> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com> >> --- I guess this "---" should work as the end marker of changelog. >> v1 --> v2: Modified the commit message and the title. >> v2 --> v3: Change the commit message again. >> --- Another "---" here does no harm. Thanks, Akira > >> Documentation/PCI/pcieaer-howto.rst | 2 +- >> drivers/pci/pcie/Kconfig | 2 +- >> drivers/pci/pcie/aer_inject.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-)
On Fri, Aug 05, 2022 at 10:52:38AM +0000, Huang Shijie wrote: > The aer-inject tree has been moved to: > https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git > Update the links. > > Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com> > --- > v1 --> v2: Modified the commit message and the title. > v2 --> v3: Change the commit message again. > --- > Documentation/PCI/pcieaer-howto.rst | 2 +- > drivers/pci/pcie/Kconfig | 2 +- > drivers/pci/pcie/aer_inject.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/PCI/pcieaer-howto.rst b/Documentation/PCI/pcieaer-howto.rst > index 0b36b9ebfa4b..b31fc9a0edbc 100644 > --- a/Documentation/PCI/pcieaer-howto.rst > +++ b/Documentation/PCI/pcieaer-howto.rst > @@ -294,7 +294,7 @@ After reboot with new kernel or insert the module, a device file named > Then, you need a user space tool named aer-inject, which can be gotten > from: > > - https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ > + https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ I don't get it. Both links work fine for me. Do the cgit links redirect to pub/scm, but cgit is deprecated? I'm happy to apply if that's the case, but I'd like a pointer to the reason for the change, e.g., email that says cgit is being deprecated. Bjorn
在 2022/9/28 7:47, Bjorn Helgaas 写道: > On Fri, Aug 05, 2022 at 10:52:38AM +0000, Huang Shijie wrote: >> The aer-inject tree has been moved to: >> https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git >> Update the links. >> >> Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com> >> --- >> v1 --> v2: Modified the commit message and the title. >> v2 --> v3: Change the commit message again. >> --- >> Documentation/PCI/pcieaer-howto.rst | 2 +- >> drivers/pci/pcie/Kconfig | 2 +- >> drivers/pci/pcie/aer_inject.c | 2 +- >> 3 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/PCI/pcieaer-howto.rst b/Documentation/PCI/pcieaer-howto.rst >> index 0b36b9ebfa4b..b31fc9a0edbc 100644 >> --- a/Documentation/PCI/pcieaer-howto.rst >> +++ b/Documentation/PCI/pcieaer-howto.rst >> @@ -294,7 +294,7 @@ After reboot with new kernel or insert the module, a device file named >> Then, you need a user space tool named aer-inject, which can be gotten >> from: >> >> - https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ >> + https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ > I don't get it. Both links work fine for me. Do the cgit links Yes, the links work fine again. It did not work when I created this patch :) .. Please ignore this patch. Thanks Huang Shijie > redirect to pub/scm, but cgit is deprecated? I'm happy to apply if > that's the case, but I'd like a pointer to the reason for the change, > e.g., email that says cgit is being deprecated. > > Bjorn
diff --git a/Documentation/PCI/pcieaer-howto.rst b/Documentation/PCI/pcieaer-howto.rst index 0b36b9ebfa4b..b31fc9a0edbc 100644 --- a/Documentation/PCI/pcieaer-howto.rst +++ b/Documentation/PCI/pcieaer-howto.rst @@ -294,7 +294,7 @@ After reboot with new kernel or insert the module, a device file named Then, you need a user space tool named aer-inject, which can be gotten from: - https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ + https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ More information about aer-inject can be found in the document comes with its source code. diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig index 788ac8df3f9d..d6ea0fd9892d 100644 --- a/drivers/pci/pcie/Kconfig +++ b/drivers/pci/pcie/Kconfig @@ -43,7 +43,7 @@ config PCIEAER_INJECT error injection can fake almost all kinds of errors with the help of a user space helper tool aer-inject, which can be gotten from: - https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ + https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ # # PCI Express ECRC diff --git a/drivers/pci/pcie/aer_inject.c b/drivers/pci/pcie/aer_inject.c index 2dab275d252f..262b06b0dc1d 100644 --- a/drivers/pci/pcie/aer_inject.c +++ b/drivers/pci/pcie/aer_inject.c @@ -6,7 +6,7 @@ * trigger various real hardware errors. Software based error * injection can fake almost all kinds of errors with the help of a * user space helper tool aer-inject, which can be gotten from: - * https://git.kernel.org/cgit/linux/kernel/git/gong.chen/aer-inject.git/ + * https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git/ * * Copyright 2009 Intel Corporation. * Huang Ying <ying.huang@intel.com>
The aer-inject tree has been moved to: https://git.kernel.org/pub/scm/linux/kernel/git/gong.chen/aer-inject.git Update the links. Signed-off-by: Huang Shijie <shijie@os.amperecomputing.com> --- v1 --> v2: Modified the commit message and the title. v2 --> v3: Change the commit message again. --- Documentation/PCI/pcieaer-howto.rst | 2 +- drivers/pci/pcie/Kconfig | 2 +- drivers/pci/pcie/aer_inject.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)