| Message ID | 20220629141000.18111-6-johan+linaro@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: qcom: Add support for SC8280XP and SA8540P | expand |
On 29/06/2022 16:09, Johan Hovold wrote: > SA8540P is a new platform related to SC8280XP but which uses a single > host interrupt for MSI routing. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index a039f6110322..e9a7c8c783e7 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -25,6 +25,7 @@ properties: > - qcom,pcie-ipq4019 > - qcom,pcie-ipq8074 > - qcom,pcie-qcs404 > + - qcom,pcie-sa8540p > - qcom,pcie-sc7280 > - qcom,pcie-sc8180x > - qcom,pcie-sc8280xp > @@ -603,6 +604,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,pcie-sa8540p > - qcom,pcie-sc8280xp > then: > properties: > @@ -720,6 +722,7 @@ allOf: > - qcom,pcie-ipq8064 > - qcom,pcie-ipq8064-v2 > - qcom,pcie-ipq8074 > + - qcom,pcie-sa8540p Alphabetical order please. > - qcom,pcie-qcs404 > then: > properties: Best regards, Krzysztof
On Fri, Jul 01, 2022 at 10:38:24AM +0200, Krzysztof Kozlowski wrote: > On 29/06/2022 16:09, Johan Hovold wrote: > > SA8540P is a new platform related to SC8280XP but which uses a single > > host interrupt for MSI routing. > > > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > > --- > > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > index a039f6110322..e9a7c8c783e7 100644 > > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > > @@ -25,6 +25,7 @@ properties: > > - qcom,pcie-ipq4019 > > - qcom,pcie-ipq8074 > > - qcom,pcie-qcs404 > > + - qcom,pcie-sa8540p > > - qcom,pcie-sc7280 > > - qcom,pcie-sc8180x > > - qcom,pcie-sc8280xp > > @@ -603,6 +604,7 @@ allOf: > > compatible: > > contains: > > enum: > > + - qcom,pcie-sa8540p > > - qcom,pcie-sc8280xp > > then: > > properties: > > @@ -720,6 +722,7 @@ allOf: > > - qcom,pcie-ipq8064 > > - qcom,pcie-ipq8064-v2 > > - qcom,pcie-ipq8074 > > + - qcom,pcie-sa8540p > > Alphabetical order please. Oops. Will fix. > > - qcom,pcie-qcs404 Johan
On Wed, Jun 29, 2022 at 04:09:55PM +0200, Johan Hovold wrote: > SA8540P is a new platform related to SC8280XP but which uses a single > host interrupt for MSI routing. > The newer chipsets are supposed to use 8 MSI's. How come this one uses only 1? Thanks, Mani > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > index a039f6110322..e9a7c8c783e7 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml > @@ -25,6 +25,7 @@ properties: > - qcom,pcie-ipq4019 > - qcom,pcie-ipq8074 > - qcom,pcie-qcs404 > + - qcom,pcie-sa8540p > - qcom,pcie-sc7280 > - qcom,pcie-sc8180x > - qcom,pcie-sc8280xp > @@ -603,6 +604,7 @@ allOf: > compatible: > contains: > enum: > + - qcom,pcie-sa8540p > - qcom,pcie-sc8280xp > then: > properties: > @@ -720,6 +722,7 @@ allOf: > - qcom,pcie-ipq8064 > - qcom,pcie-ipq8064-v2 > - qcom,pcie-ipq8074 > + - qcom,pcie-sa8540p > - qcom,pcie-qcs404 > then: > properties: > -- > 2.35.1 >
On Sat, Jul 09, 2022 at 01:32:03PM +0530, Manivannan Sadhasivam wrote: > On Wed, Jun 29, 2022 at 04:09:55PM +0200, Johan Hovold wrote: > > SA8540P is a new platform related to SC8280XP but which uses a single > > host interrupt for MSI routing. > > > > The newer chipsets are supposed to use 8 MSI's. How come this one uses only 1? No idea, but the people with access to the documentation could not find more than one interrupt for SA8540P (unlike SC8280XP). Johan
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index a039f6110322..e9a7c8c783e7 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -25,6 +25,7 @@ properties: - qcom,pcie-ipq4019 - qcom,pcie-ipq8074 - qcom,pcie-qcs404 + - qcom,pcie-sa8540p - qcom,pcie-sc7280 - qcom,pcie-sc8180x - qcom,pcie-sc8280xp @@ -603,6 +604,7 @@ allOf: compatible: contains: enum: + - qcom,pcie-sa8540p - qcom,pcie-sc8280xp then: properties: @@ -720,6 +722,7 @@ allOf: - qcom,pcie-ipq8064 - qcom,pcie-ipq8064-v2 - qcom,pcie-ipq8074 + - qcom,pcie-sa8540p - qcom,pcie-qcs404 then: properties:
SA8540P is a new platform related to SC8280XP but which uses a single host interrupt for MSI routing. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ 1 file changed, 3 insertions(+)