| Message ID | 20211203192454.32624-1-sergio.paracuellos@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] PCI: mt7621: Convert driver into 'bool' | expand |
On Fri, Dec 03, 2021 at 08:24:54PM +0100, Sergio Paracuellos wrote: > Driver is not ready yet to be compiled as a module since it depends on some > MIPS not exported symbols. We have the following current problems: > > Building mips:allmodconfig ... failed > -------------- > Error log: > ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > Temporarily move from 'tristate' to 'bool' until a better solution is ready. > > Also RALINK is redundant because SOC_MT7621 already depends on it. Hence, > simplify condition. > > Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver"). > Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > --- > Changes in v3: > - Adjust subject to follow convention: > s/PCI: mt7621: Kconfig:/PCI: mt7621:/ > Changes in v2: > - Add Guenter's 'Reviewed-and-tested-by'. > - s/after/until > drivers/pci/controller/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 93b141110537..7fc5135ffbbf 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -332,8 +332,8 @@ config PCIE_APPLE > If unsure, say Y if you have an Apple Silicon system. > > config PCIE_MT7621 > - tristate "MediaTek MT7621 PCIe Controller" > - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST) > + bool "MediaTek MT7621 PCIe Controller" > + depends on SOC_MT7621 || (MIPS && COMPILE_TEST) > select PHY_MT7621_PCI > default SOC_MT7621 > help > -- > 2.33.0 > Hi Sergio, I believe this is still to be pulled in some tree, just asking for confirmation, please let me know and I will queue it. Thanks, Lorenzo
Hi Lorenzo, On Wed, Jan 5, 2022 at 3:01 PM Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> wrote: > > On Fri, Dec 03, 2021 at 08:24:54PM +0100, Sergio Paracuellos wrote: > > Driver is not ready yet to be compiled as a module since it depends on some > > MIPS not exported symbols. We have the following current problems: > > > > Building mips:allmodconfig ... failed > > -------------- > > Error log: > > ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o > > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > > > Temporarily move from 'tristate' to 'bool' until a better solution is ready. > > > > Also RALINK is redundant because SOC_MT7621 already depends on it. Hence, > > simplify condition. > > > > Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver"). > > Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net> > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> > > --- > > Changes in v3: > > - Adjust subject to follow convention: > > s/PCI: mt7621: Kconfig:/PCI: mt7621:/ > > Changes in v2: > > - Add Guenter's 'Reviewed-and-tested-by'. > > - s/after/until > > drivers/pci/controller/Kconfig | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > > index 93b141110537..7fc5135ffbbf 100644 > > --- a/drivers/pci/controller/Kconfig > > +++ b/drivers/pci/controller/Kconfig > > @@ -332,8 +332,8 @@ config PCIE_APPLE > > If unsure, say Y if you have an Apple Silicon system. > > > > config PCIE_MT7621 > > - tristate "MediaTek MT7621 PCIe Controller" > > - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST) > > + bool "MediaTek MT7621 PCIe Controller" > > + depends on SOC_MT7621 || (MIPS && COMPILE_TEST) > > select PHY_MT7621_PCI > > default SOC_MT7621 > > help > > -- > > 2.33.0 > > > > Hi Sergio, > > I believe this is still to be pulled in some tree, just asking for > confirmation, please let me know and I will queue it. This is already in Linus'tree [0]. > > Thanks, > Lorenzo Best regards, Sergio Paracuellos [0]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/pci/controller?id=aa50faff4416c869b52dff68a937c84d29e12f4b
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index 93b141110537..7fc5135ffbbf 100644 --- a/drivers/pci/controller/Kconfig +++ b/drivers/pci/controller/Kconfig @@ -332,8 +332,8 @@ config PCIE_APPLE If unsure, say Y if you have an Apple Silicon system. config PCIE_MT7621 - tristate "MediaTek MT7621 PCIe Controller" - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST) + bool "MediaTek MT7621 PCIe Controller" + depends on SOC_MT7621 || (MIPS && COMPILE_TEST) select PHY_MT7621_PCI default SOC_MT7621 help
Driver is not ready yet to be compiled as a module since it depends on some MIPS not exported symbols. We have the following current problems: Building mips:allmodconfig ... failed -------------- Error log: ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! Temporarily move from 'tristate' to 'bool' until a better solution is ready. Also RALINK is redundant because SOC_MT7621 already depends on it. Hence, simplify condition. Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver"). Reviewed-and-tested-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> --- Changes in v3: - Adjust subject to follow convention: s/PCI: mt7621: Kconfig:/PCI: mt7621:/ Changes in v2: - Add Guenter's 'Reviewed-and-tested-by'. - s/after/until drivers/pci/controller/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)