| Message ID | 20211201213402.22802-1-sergio.paracuellos@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: mt7621: Kconfig: Convert driver into 'bool' | expand |
On 12/1/21 1:34 PM, Sergio Paracuellos wrote: > Driver is not ready yet to be compiled as a module since it depends on some > MIPS not exported symbols. We have the following current problems: > > Building mips:allmodconfig ... failed > -------------- > Error log: > ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o > ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! > ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! > > Temporarily move from 'tristate' to 'bool' after a better solution is ready. s/after/until/ > > Also RALINK is redundant because SOC_MT7621 already depends on it. Hence, > simplify condition. > > Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver"). > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> Reviewed-and-Tested-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/pci/controller/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index 93b141110537..7fc5135ffbbf 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -332,8 +332,8 @@ config PCIE_APPLE > If unsure, say Y if you have an Apple Silicon system. > > config PCIE_MT7621 > - tristate "MediaTek MT7621 PCIe Controller" > - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST) > + bool "MediaTek MT7621 PCIe Controller" > + depends on SOC_MT7621 || (MIPS && COMPILE_TEST) > select PHY_MT7621_PCI > default SOC_MT7621 > help >
s/PCI: mt7621: Kconfig:/PCI: mt7621:/ in subject. You can run "git log --oneline drivers/pci/controller/Kconfig" to learn the convention. On Wed, Dec 01, 2021 at 10:34:02PM +0100, Sergio Paracuellos wrote: > Driver is not ready yet to be compiled as a module since it depends on some > MIPS not exported symbols. We have the following current problems: > ...
On Fri, Dec 3, 2021 at 7:23 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > s/PCI: mt7621: Kconfig:/PCI: mt7621:/ > > in subject. You can run "git log --oneline > drivers/pci/controller/Kconfig" to learn the convention. Will take it into account from now, thanks. Sent: https://lore.kernel.org/linux-pci/20211203192454.32624-1-sergio.paracuellos@gmail.com/T/#u Best regards, Sergio Paracuellos > > On Wed, Dec 01, 2021 at 10:34:02PM +0100, Sergio Paracuellos wrote: > > Driver is not ready yet to be compiled as a module since it depends on some > > MIPS not exported symbols. We have the following current problems: > > ...
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig index 93b141110537..7fc5135ffbbf 100644 --- a/drivers/pci/controller/Kconfig +++ b/drivers/pci/controller/Kconfig @@ -332,8 +332,8 @@ config PCIE_APPLE If unsure, say Y if you have an Apple Silicon system. config PCIE_MT7621 - tristate "MediaTek MT7621 PCIe Controller" - depends on (RALINK && SOC_MT7621) || (MIPS && COMPILE_TEST) + bool "MediaTek MT7621 PCIe Controller" + depends on SOC_MT7621 || (MIPS && COMPILE_TEST) select PHY_MT7621_PCI default SOC_MT7621 help
Driver is not ready yet to be compiled as a module since it depends on some MIPS not exported symbols. We have the following current problems: Building mips:allmodconfig ... failed -------------- Error log: ERROR: modpost: missing MODULE_LICENSE() in drivers/pci/controller/pcie-mt7621.o ERROR: modpost: "mips_cm_unlock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cpc_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_lock_other" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_cm_is64" [drivers/pci/controller/pcie-mt7621.ko] undefined! ERROR: modpost: "mips_gcr_base" [drivers/pci/controller/pcie-mt7621.ko] undefined! Temporarily move from 'tristate' to 'bool' after a better solution is ready. Also RALINK is redundant because SOC_MT7621 already depends on it. Hence, simplify condition. Fixes: 2bdd5238e756 ("PCI: mt7621: Add MediaTek MT7621 PCIe host controller driver"). Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com> --- drivers/pci/controller/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)