[1/3] PCI: hv: Remove unnecessary integer promotion from dev_err()

Internally, printk() et al already correctly handles the standard
integer promotions, so there is no need to explicitly "%h" modifier as
part of a format string such as "%hx".

Thus, drop the "%h" modifier as it's completely unnecessary (N.B. this
wouldn't be true for the sscanf() function family), and match preferred
coding style.

Related:
  commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary
  commit 70eb2275ff8e ("checkpatch: add warning for unnecessary use of %h[xudi] and %hh[xudi]")
  https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@mail.gmail.com/

No change to functionality intended.

Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 drivers/pci/controller/pci-hyperv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

On Fri, Oct 08, 2021 at 10:27:30PM +0000, Krzysztof Wilczyński wrote:
> Internally, printk() et al already correctly handles the standard
> integer promotions, so there is no need to explicitly "%h" modifier as
> part of a format string such as "%hx".
> 
> Thus, drop the "%h" modifier as it's completely unnecessary (N.B. this
> wouldn't be true for the sscanf() function family), and match preferred
> coding style.
> 
> Related:
>   commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary
>   commit 70eb2275ff8e ("checkpatch: add warning for unnecessary use of %h[xudi] and %hh[xudi]")
>   https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@mail.gmail.com/
> 
> No change to functionality intended.

Applied 1/3 and 3/3 to pci/misc for v5.16, thanks!

For 2/3, I think we might want to convert the VF ID to be unsigned
consistently.

> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
> ---
>  drivers/pci/controller/pci-hyperv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 67c46e52c0dc..6733cb14e775 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -3126,14 +3126,14 @@ static int hv_pci_probe(struct hv_device *hdev,
>  
>  	if (dom == HVPCI_DOM_INVALID) {
>  		dev_err(&hdev->device,
> -			"Unable to use dom# 0x%hx or other numbers", dom_req);
> +			"Unable to use dom# 0x%x or other numbers", dom_req);
>  		ret = -EINVAL;
>  		goto free_bus;
>  	}
>  
>  	if (dom != dom_req)
>  		dev_info(&hdev->device,
> -			 "PCI dom# 0x%hx has collision, using 0x%hx",
> +			 "PCI dom# 0x%x has collision, using 0x%x",
>  			 dom_req, dom);
>  
>  	hbus->bridge->domain_nr = dom;
> -- 
> 2.33.0
>

Hi Bjorn,

> > Internally, printk() et al already correctly handles the standard
> > integer promotions, so there is no need to explicitly "%h" modifier as
> > part of a format string such as "%hx".
> > 
> > Thus, drop the "%h" modifier as it's completely unnecessary (N.B. this
> > wouldn't be true for the sscanf() function family), and match preferred
> > coding style.
> > 
> > Related:
> >   commit cbacb5ab0aa0 ("docs: printk-formats: Stop encouraging use of unnecessary
> >   commit 70eb2275ff8e ("checkpatch: add warning for unnecessary use of %h[xudi] and %hh[xudi]")
> >   https://lore.kernel.org/lkml/CAHk-=wgoxnmsj8GEVFJSvTwdnWm8wVJthefNk2n6+4TC=20e0Q@mail.gmail.com/
> > 
> > No change to functionality intended.
> 
> Applied 1/3 and 3/3 to pci/misc for v5.16, thanks!
> 
> For 2/3, I think we might want to convert the VF ID to be unsigned
> consistently.

Will do!  I am going to send a separate patch for it.

	Krzysztof