| Message ID | 20210119102757.2395-1-dnlplm@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] PCI: add Telit Vendor ID | expand |
On Tue, Jan 19, 2021 at 11:27:57AM +0100, Daniele Palmas wrote: > Add Telit Vendor ID to pci_ids.h From the top of the file: * Do not add new entries to this file unless the definitions * are shared between multiple drivers. If this is the case, include this patch in a series that adds multiple uses or mention the uses in this commit log. > Signed-off-by: Daniele Palmas <dnlplm@gmail.com> > --- > Reference: https://pcisig.com/membership/member-companies?combine=telit > --- > include/linux/pci_ids.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index d8156a5dbee8..b10a04783287 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2590,6 +2590,8 @@ > > #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36 > > +#define PCI_VENDOR_ID_TELIT 0x1c5d > + > #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 > #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001 > > -- > 2.17.1 >
On Tue, Jan 19, 2021 at 04:06:21PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 19, 2021 at 11:27:57AM +0100, Daniele Palmas wrote: > > Add Telit Vendor ID to pci_ids.h > > From the top of the file: > > * Do not add new entries to this file unless the definitions > * are shared between multiple drivers. > > If this is the case, include this patch in a series that adds multiple > uses or mention the uses in this commit log. Also, when you do, follow the subject convention (run "git log --oneline include/linux/pci_ids.h" to see it). > > Signed-off-by: Daniele Palmas <dnlplm@gmail.com> > > --- > > Reference: https://pcisig.com/membership/member-companies?combine=telit > > --- > > include/linux/pci_ids.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index d8156a5dbee8..b10a04783287 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2590,6 +2590,8 @@ > > > > #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36 > > > > +#define PCI_VENDOR_ID_TELIT 0x1c5d > > + > > #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 > > #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001 > > > > -- > > 2.17.1 > >
Hi Daniele, On Tue, 19 Jan 2021 at 23:06, Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Tue, Jan 19, 2021 at 11:27:57AM +0100, Daniele Palmas wrote: > > Add Telit Vendor ID to pci_ids.h > > From the top of the file: > > * Do not add new entries to this file unless the definitions > * are shared between multiple drivers. > > If this is the case, include this patch in a series that adds multiple > uses or mention the uses in this commit log. Ok, in that case, you can add this define directly in mhi_pci_generic along with a new entry for matching the sub-vendor/device IDs of your module. Regards, Loic > > > Signed-off-by: Daniele Palmas <dnlplm@gmail.com> > > --- > > Reference: https://pcisig.com/membership/member-companies?combine=telit > > --- > > include/linux/pci_ids.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index d8156a5dbee8..b10a04783287 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2590,6 +2590,8 @@ > > > > #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36 > > > > +#define PCI_VENDOR_ID_TELIT 0x1c5d > > + > > #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 > > #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001 > > > > -- > > 2.17.1 > >
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index d8156a5dbee8..b10a04783287 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2590,6 +2590,8 @@ #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36 +#define PCI_VENDOR_ID_TELIT 0x1c5d + #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8 #define PCI_SUBSYSTEM_ID_CIRCUITCO_MINNOWBOARD 0x0001
Add Telit Vendor ID to pci_ids.h Signed-off-by: Daniele Palmas <dnlplm@gmail.com> --- Reference: https://pcisig.com/membership/member-companies?combine=telit --- include/linux/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+)