| Message ID | 20200902144344.16684-3-pali@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: aardvark: Fix comphy with old ATF | expand |
On Wed, 02 Sep 2020 16:43:44 +0200, Pali Rohár wrote: > Old ATF automatically power on pcie phy and does not provide SMC call for > phy power on functionality which leads to aardvark initialization failure: > > [ 0.330134] mvebu-a3700-comphy d0018300.phy: unsupported SMC call, try updating your firmware > [ 0.338846] phy phy-d0018300.phy.1: phy poweron failed --> -95 > [ 0.344753] advk-pcie d0070000.pcie: Failed to initialize PHY (-95) > [ 0.351160] advk-pcie: probe of d0070000.pcie failed with error -95 > > This patch fixes above failure by ignoring 'not supported' error in > aardvark driver. In this case it is expected that phy is already power on. > > Signed-off-by: Pali Rohár <pali@kernel.org> > Fixes: 366697018c9a ("PCI: aardvark: Add PHY support") > --- > drivers/pci/controller/pci-aardvark.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index c5d1bb3d52e4..e1a80c35c73d 100644 --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -1108,7 +1108,9 @@ static int advk_pcie_enable_phy(struct advk_pcie *pcie) } ret = phy_power_on(pcie->phy); - if (ret) { + if (ret == -EOPNOTSUPP) { + dev_warn(&pcie->pdev->dev, "PHY unsupported by firmware\n"); + } else if (ret) { phy_exit(pcie->phy); return ret; }
Old ATF automatically power on pcie phy and does not provide SMC call for phy power on functionality which leads to aardvark initialization failure: [ 0.330134] mvebu-a3700-comphy d0018300.phy: unsupported SMC call, try updating your firmware [ 0.338846] phy phy-d0018300.phy.1: phy poweron failed --> -95 [ 0.344753] advk-pcie d0070000.pcie: Failed to initialize PHY (-95) [ 0.351160] advk-pcie: probe of d0070000.pcie failed with error -95 This patch fixes above failure by ignoring 'not supported' error in aardvark driver. In this case it is expected that phy is already power on. Signed-off-by: Pali Rohár <pali@kernel.org> Fixes: 366697018c9a ("PCI: aardvark: Add PHY support") --- drivers/pci/controller/pci-aardvark.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)