| Message ID | 20200415084953.6533-1-yanaijie@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | PCI: dwc: intel: make intel_pcie_cpu_addr() static | expand |
On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol > 'intel_pcie_cpu_addr' was not declared. Should it be static? Please, learn how to use get_maintainers.pl to avoid spamming people. Hint: scripts/get_maintainer.pl --git --git-min-percent=67 would give advantage, though it still requires a common sense to be applied. > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c > index fc2a12212dec..2d8dbb318087 100644 > --- a/drivers/pci/controller/dwc/pcie-intel-gw.c > +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c > @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp) > return 0; > } > > -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr) > +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr) > { > return cpu_addr + BUS_IATU_OFFSET; > } > -- > 2.21.1 >
在 2020/4/15 18:07, Andy Shevchenko 写道: > On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote: >> Fix the following sparse warning: >> >> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol >> 'intel_pcie_cpu_addr' was not declared. Should it be static? > > Please, learn how to use get_maintainers.pl to avoid spamming people. > Hint: > scripts/get_maintainer.pl --git --git-min-percent=67 > would give advantage, though it still requires a common sense to be applied. > I'm so sorry to bother you with this. I will be more careful when I'm sending patches. Thanks, Jason
On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote: > Fix the following sparse warning: > > drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol > 'intel_pcie_cpu_addr' was not declared. Should it be static? > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Jason Yan <yanaijie@huawei.com> > --- > drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to pci/dwc, thanks. Lorenzo > diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c > index fc2a12212dec..2d8dbb318087 100644 > --- a/drivers/pci/controller/dwc/pcie-intel-gw.c > +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c > @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp) > return 0; > } > > -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr) > +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr) > { > return cpu_addr + BUS_IATU_OFFSET; > } > -- > 2.21.1 >
diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c index fc2a12212dec..2d8dbb318087 100644 --- a/drivers/pci/controller/dwc/pcie-intel-gw.c +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp) return 0; } -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr) +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr) { return cpu_addr + BUS_IATU_OFFSET; }
Fix the following sparse warning: drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol 'intel_pcie_cpu_addr' was not declared. Should it be static? Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Jason Yan <yanaijie@huawei.com> --- drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)