diff mbox series

[4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM by default

Message ID 20200415001244.144623-5-helgaas@kernel.org
State New
Headers show
Series PCI: Don't select Kconfig symbols by default | expand

Commit Message

Bjorn Helgaas April 15, 2020, 12:12 a.m. UTC 
From: Bjorn Helgaas <bhelgaas@google.com>

PCIe Active State Power Management (ASPM) is optional and there's no need
for it to be selected by default.

Remove the "default y" for CONFIG_PCIEASPM.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/pci/pcie/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Bjorn Helgaas June 1, 2020, 4:31 p.m. UTC | #1 
On Tue, Apr 14, 2020 at 07:12:44PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> PCIe Active State Power Management (ASPM) is optional and there's no need
> for it to be selected by default.
> 
> Remove the "default y" for CONFIG_PCIEASPM.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>

I dropped this patch for now.

Without CONFIG_PCIEASPM, Linux doesn't request control of *any*
features via _OSC (see ACPI_PCIE_REQ_SUPPORT), which means we can't
use PCIe PME to resume from runtime suspend.

https://bugzilla.redhat.com/show_bug.cgi?id=638912
https://lore.kernel.org/r/2e1ee784-7493-284b-96f9-96b2e0c4b817@gmail.com

> ---
>  drivers/pci/pcie/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index 9cd31331aee9..5b7b460a8a98 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -62,7 +62,6 @@ config PCIE_ECRC
>  #
>  config PCIEASPM
>  	bool "PCI Express ASPM control" if EXPERT
> -	default y
>  	help
>  	  This enables OS control over PCI Express ASPM (Active State
>  	  Power Management) and Clock Power Management. ASPM supports
> -- 
> 2.26.0.110.g2183baf09c-goog
>
diff mbox series

Patch

diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
index 9cd31331aee9..5b7b460a8a98 100644
--- a/drivers/pci/pcie/Kconfig
+++ b/drivers/pci/pcie/Kconfig
@@ -62,7 +62,6 @@  config PCIE_ECRC
 #
 config PCIEASPM
 	bool "PCI Express ASPM control" if EXPERT
-	default y
 	help
 	  This enables OS control over PCI Express ASPM (Active State
 	  Power Management) and Clock Power Management. ASPM supports