From patchwork Mon Apr 13 05:32:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiaxun Yang X-Patchwork-Id: 1269697 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=flygoat.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=flygoat.com header.i=@flygoat.com header.a=rsa-sha256 header.s=vultr header.b=P6bbNlDM; dkim-atps=neutral Received: from vger.kernel.org (unknown [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 490yFJ3C6gz9sVx for ; Mon, 13 Apr 2020 15:42:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729069AbgDMFmb (ORCPT ); Mon, 13 Apr 2020 01:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.18]:42860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728358AbgDMFma (ORCPT ); Mon, 13 Apr 2020 01:42:30 -0400 Received: from vultr.net.flygoat.com (vultr.net.flygoat.com [IPv6:2001:19f0:6001:3633:5400:2ff:fe8c:553]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69DB6C008679; Sun, 12 Apr 2020 22:42:30 -0700 (PDT) Received: from localhost.localdomain (unknown [IPv6:2001:da8:20f:4430:250:56ff:fe9a:7470]) by vultr.net.flygoat.com (Postfix) with ESMTPSA id 426DE20CF8; Mon, 13 Apr 2020 05:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=flygoat.com; s=vultr; t=1586756049; bh=KZzC8hDq/L5Ksu7mwvgHXdRRg3Pi1Gnhas1jIt28u50=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P6bbNlDMWmSNeWxbTzqMAXSopRk5GTcT3hOk9EVI+P06pr2cQKJPJXaRNmAH1Cjr5 Tul/Y9bSZiZKuQk/Ecxj3mXfrGlw8KEXRRQSYFXCiDOT7g1HnDGRZJRlm2NnQfr3VD v18Hr00bAcBGUtniaBxUttIrJp3YJ7n/UuwMy7kmZPtuGyD0v0NUWUmYc048QJ386l xcuS+gS52dRLW/XkBJj2Km6jdBkTIko+4+PTZ/akTepf+Y3zO9dxylZLSaM89rMkpj ih1/j7eteO0kf2zZ3Rnof/VFZnq1zHKOqIs6vFGUZdwMYCgCEvZoAW44AAaxjyd7Ft MlSNG/TLRgGYA== From: Jiaxun Yang To: linux-mips@vger.kernel.org Cc: Jiaxun Yang , Bjorn Helgaas , Rob Herring , Thomas Bogendoerfer , Huacai Chen , Lorenzo Pieralisi , Andrew Murray , Paul Burton , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/5] PCI: OF: Don't remap iospace on unsupported platform Date: Mon, 13 Apr 2020 13:32:09 +0800 Message-Id: <20200413053222.3976680-1-jiaxun.yang@flygoat.com> X-Mailer: git-send-email 2.26.0.rc2 In-Reply-To: <20200330114239.1112759-1-jiaxun.yang@flygoat.com> References: <20200330114239.1112759-1-jiaxun.yang@flygoat.com> MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org There are some platforms doesn't support iospace remapping like MIPS. However, our PCI code will try to remap iospace unconditionally and reject io resources on these platforms. So we should remove iospace remapping check and use a range check instead on these platforms. Signed-off-by: Jiaxun Yang --- drivers/pci/of.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/pci/of.c b/drivers/pci/of.c index 81ceeaa6f1d5..36e8761b66c6 100644 --- a/drivers/pci/of.c +++ b/drivers/pci/of.c @@ -547,12 +547,21 @@ int pci_parse_request_of_pci_ranges(struct device *dev, switch (resource_type(res)) { case IORESOURCE_IO: +#if defined(PCI_IOBASE) && defined(CONFIG_MMU) err = devm_pci_remap_iospace(dev, res, iobase); if (err) { dev_warn(dev, "error %d: failed to map resource %pR\n", err, res); resource_list_destroy_entry(win); } +#else + /* Simply check if IO is inside the range */ + if (res->end > IO_SPACE_LIMIT) { + dev_warn(dev, "resource %pR out of the IO range\n", + res); + resource_list_destroy_entry(win); + } +#endif break; case IORESOURCE_MEM: res_valid |= !(res->flags & IORESOURCE_PREFETCH);