From patchwork Thu Apr 9 16:16:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Saheed O. Bolarinwa" X-Patchwork-Id: 1268680 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=IX6Agv0U; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48ymVB4hRVz9sSj for ; Fri, 10 Apr 2020 02:16:18 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726757AbgDIQQQ (ORCPT ); Thu, 9 Apr 2020 12:16:16 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50453 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726579AbgDIQQQ (ORCPT ); Thu, 9 Apr 2020 12:16:16 -0400 Received: by mail-wm1-f67.google.com with SMTP id x25so365898wmc.0 for ; Thu, 09 Apr 2020 09:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=b+mOxU4J72rHc/2vUWqnDVVF3rP/Hnl93uURK+ooxfA=; b=IX6Agv0Uy+Tndn6vnCw1Mw+a5A/faJoFJP3zJFzUtD9M7hRqQmfeoGw1csOfXof2vQ Mbp7q0q0qQeLFAq5NvT1mQK3GOBH9n99ojgOcgFLtX1aOUF5E31ZlwT1FAbdUtOtsLrv jFWAISuQenK+aVxIaC29f8i2rNci/gsioC2SGzl+18ri+8rVTfqmNEt/8g6VC/SrBqxi GJkPQjVv8/s8VMszcNd8gDDPi1kSfU73W5PxlvVbEPTwGKKK5aUNhepKXcTVCXuiTScu EOD11bjT5x20a89K3AYTpFNqGl70y8GBSpfe+s/Qv3XWOJEBQ74eERHJPTrZ2/O9BiEz /phw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=b+mOxU4J72rHc/2vUWqnDVVF3rP/Hnl93uURK+ooxfA=; b=LDcHR0bnwLcMex4RK+IijUkJ1ziwcNJu29jb8A451XFSmQXJdLSsl9A5bwJ+Zq972c pRCSjyJMC9M39xEtefsdoDpxZDXRXbx248v52SOMaHjHHwB1K70xwPTq38dBoRdvNfY0 yPH61/iZvGWFbItgZM/KUPpnM/+wfqSGOHwDLKy0yDXZ8gKv98UOh9T7i725Hl3nwPQc C8G/ZI9IzuyuW+pINpIInhXYLontgymaegMW61DE+GYOkiAgoxqHSGOaNZ+Z668SF9cS qL6I4afky+dpMZJESm4GESYURVybJ+cctfZsrxbK5HbiQbrbAjHHdq8zrMs+rLHK3biy pmGw== X-Gm-Message-State: AGi0Puau0QXRlnfcZ8tFAz3dqUvMxhmBbehDjlwwKaeV+Xis5L/EVnQq SfZEbbZAoL7LKlKvU0UQcGA8Vne6/UTGnQ== X-Google-Smtp-Source: APiQypLH+aj1zHlXs4E0ZqZpASyY9Be79agUhFPZGbJUSTfWulkxHbG25RmTYUMH0J3HlBiLQ5iIgw== X-Received: by 2002:a05:600c:24cf:: with SMTP id 15mr619235wmu.94.1586448974446; Thu, 09 Apr 2020 09:16:14 -0700 (PDT) Received: from localhost.localdomain (51B786A4.dsl.pool.telekom.hu. [81.183.134.164]) by smtp.gmail.com with ESMTPSA id h6sm4440436wmf.31.2020.04.09.09.16.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 09:16:13 -0700 (PDT) From: Bolarinwa Olayemi Saheed To: helgaas@kernel.org Cc: Bolarinwa Olayemi Saheed , bjorn@helgaas.com, skhan@linuxfoundation.org, linux-pci@vger.kernel.org Subject: [PATCH] Replace -EINVAL with PCIBIOS_BAD_REGISTER_NUMBER Date: Thu, 9 Apr 2020 18:16:09 +0200 Message-Id: <20200409161609.2034-1-refactormyself@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Signed-off-by: Bolarinwa Olayemi Saheed Suggested-by: Bjorn Helgaas --- drivers/pci/access.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pci/access.c b/drivers/pci/access.c index 79c4a2ef269a..451f2b8b2b3c 100644 --- a/drivers/pci/access.c +++ b/drivers/pci/access.c @@ -409,7 +409,7 @@ int pcie_capability_read_word(struct pci_dev *dev, int pos, u16 *val) *val = 0; if (pos & 1) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (pcie_capability_reg_implemented(dev, pos)) { ret = pci_read_config_word(dev, pci_pcie_cap(dev) + pos, val); @@ -444,7 +444,7 @@ int pcie_capability_read_dword(struct pci_dev *dev, int pos, u32 *val) *val = 0; if (pos & 3) - return -EINVAL; + return PCIBIOS_BAD_REGISTER_NUMBER; if (pcie_capability_reg_implemented(dev, pos)) { ret = pci_read_config_dword(dev, pci_pcie_cap(dev) + pos, val);