| Message ID | 20200409114118.249461-1-colin.king@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | xen/pci: remove redundant assignment to variable irq | expand |
[+cc Juergen, Boris] On Thu, Apr 09, 2020 at 12:41:18PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable irq is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> Applied to pci/virtualization for v5.9, thanks! I don't see this in linux-next yet, but if anybody else would prefer to take it, let me know and I'll drop it. > --- > arch/x86/pci/xen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c > index 91220cc25854..80272eb49230 100644 > --- a/arch/x86/pci/xen.c > +++ b/arch/x86/pci/xen.c > @@ -63,7 +63,7 @@ static int xen_pcifront_enable_irq(struct pci_dev *dev) > static int xen_register_pirq(u32 gsi, int gsi_override, int triggering, > bool set_pirq) > { > - int rc, pirq = -1, irq = -1; > + int rc, pirq = -1, irq; > struct physdev_map_pirq map_irq; > int shareable = 0; > char *name; > -- > 2.25.1 >
diff --git a/arch/x86/pci/xen.c b/arch/x86/pci/xen.c index 91220cc25854..80272eb49230 100644 --- a/arch/x86/pci/xen.c +++ b/arch/x86/pci/xen.c @@ -63,7 +63,7 @@ static int xen_pcifront_enable_irq(struct pci_dev *dev) static int xen_register_pirq(u32 gsi, int gsi_override, int triggering, bool set_pirq) { - int rc, pirq = -1, irq = -1; + int rc, pirq = -1, irq; struct physdev_map_pirq map_irq; int shareable = 0; char *name;