diff mbox series

PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT

Message ID 20200318093312.49004-1-Zhiqiang.Hou@nxp.com
State New
Headers show
Series PCI: mobiveil: Fix unmet dependency warning for PCIE_MOBIVEIL_PLAT | expand

Commit Message

Zhiqiang Hou March 18, 2020, 9:33 a.m. UTC
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
into PCIE_MOBIVEIL_PLAT.

WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
  Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
  Selected by [y]:
  - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
 drivers/pci/controller/mobiveil/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Lorenzo Pieralisi March 18, 2020, 10:35 a.m. UTC | #1
On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
> into PCIE_MOBIVEIL_PLAT.
> 
> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>   Selected by [y]:
>   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
>  drivers/pci/controller/mobiveil/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

I have applied it to pci/mobiveil for v5.7.

Thanks,
Lorenzo

> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
> index 7439991ee82c..a62d247018cf 100644
> --- a/drivers/pci/controller/mobiveil/Kconfig
> +++ b/drivers/pci/controller/mobiveil/Kconfig
> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
>  	bool "Mobiveil AXI PCIe controller"
>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>  	depends on OF
> +	depends on PCI_MSI_IRQ_DOMAIN
>  	select PCIE_MOBIVEIL_HOST
>  	help
>  	  Say Y here if you want to enable support for the Mobiveil AXI PCIe
> -- 
> 2.17.1
>
Randy Dunlap March 18, 2020, 4:27 p.m. UTC | #2
On 3/18/20 3:35 AM, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
>> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>>
>> Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
>> into PCIE_MOBIVEIL_PLAT.
>>
>> WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
>>   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>>   Selected by [y]:
>>   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
>>
>> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>> ---
>>  drivers/pci/controller/mobiveil/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
> 
> I have applied it to pci/mobiveil for v5.7.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> Thanks,
> Lorenzo
> 
>> diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
>> index 7439991ee82c..a62d247018cf 100644
>> --- a/drivers/pci/controller/mobiveil/Kconfig
>> +++ b/drivers/pci/controller/mobiveil/Kconfig
>> @@ -15,6 +15,7 @@ config PCIE_MOBIVEIL_PLAT
>>  	bool "Mobiveil AXI PCIe controller"
>>  	depends on ARCH_ZYNQMP || COMPILE_TEST
>>  	depends on OF
>> +	depends on PCI_MSI_IRQ_DOMAIN
>>  	select PCIE_MOBIVEIL_HOST
>>  	help
>>  	  Say Y here if you want to enable support for the Mobiveil AXI PCIe
>> -- 
>> 2.17.1
>>
Bjorn Helgaas March 18, 2020, 4:30 p.m. UTC | #3
On Wed, Mar 18, 2020 at 10:35:16AM +0000, Lorenzo Pieralisi wrote:
> On Wed, Mar 18, 2020 at 05:33:12PM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > 
> > Fix the follow warning by adding the dependency PCI_MSI_IRQ_DOMAIN
> > into PCIE_MOBIVEIL_PLAT.
> > 
> > WARNING: unmet direct dependencies detected for PCIE_MOBIVEIL_HOST
> >   Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> >   Selected by [y]:
> >   - PCIE_MOBIVEIL_PLAT [=y] && PCI [=y] && (ARCH_ZYNQMP || COMPILE_TEST [=y]) && OF [=y]
> > 
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  drivers/pci/controller/mobiveil/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> 
> I have applied it to pci/mobiveil for v5.7.

Thanks, I updated my "next" branch with this.
diff mbox series

Patch

diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig
index 7439991ee82c..a62d247018cf 100644
--- a/drivers/pci/controller/mobiveil/Kconfig
+++ b/drivers/pci/controller/mobiveil/Kconfig
@@ -15,6 +15,7 @@  config PCIE_MOBIVEIL_PLAT
 	bool "Mobiveil AXI PCIe controller"
 	depends on ARCH_ZYNQMP || COMPILE_TEST
 	depends on OF
+	depends on PCI_MSI_IRQ_DOMAIN
 	select PCIE_MOBIVEIL_HOST
 	help
 	  Say Y here if you want to enable support for the Mobiveil AXI PCIe