| Message ID | 20190423092825.759-2-mmaddireddy@nvidia.com |
|---|---|
| State | Superseded |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | Enable Tegra PCIe root port features | expand |
On Tue, Apr 23, 2019 at 02:57:58PM +0530, Manikanta Maddireddy wrote: > tegra_powergate_sequence_power_up() powers up partition and also enables > clock & reset. However, if a controller like PCIe have multiple clocks > & resets and they need to be enabled in a sequence, driver must use > standalone function tegra_powergate_power_on() to power up partition. > > Export tegra_powergate_power_on() to allow Tegra controller drivers to > unpower gate partition independent to clock & reset. > > Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> > --- > V2: No change > > drivers/soc/tegra/pmc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index 0c5f79528e5f..cb3de81348bd 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -701,6 +701,7 @@ int tegra_powergate_power_on(unsigned int id) > > return tegra_powergate_set(pmc, id, true); > } > +EXPORT_SYMBOL(tegra_powergate_power_on); > > /** > * tegra_powergate_power_off() - power off partition If the sequence for the PCI power partition is becoming non-standard, this is going to hamper our efforts to move to generic PM domains. But it is what it is, so let's do this for now. We might need to revise this later on if/when we come up with a better solution. Bjorn, do you want to pick this up as part of this series, given the build dependency? If so: Acked-by: Thierry Reding <treding@nvidia.com> Alternatively I could provide a stable branch for you to pull in. But I don't think it'd be necessary, the PMC driver is a fairly slow-moving target these days. Thierry
diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index 0c5f79528e5f..cb3de81348bd 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -701,6 +701,7 @@ int tegra_powergate_power_on(unsigned int id) return tegra_powergate_set(pmc, id, true); } +EXPORT_SYMBOL(tegra_powergate_power_on); /** * tegra_powergate_power_off() - power off partition
tegra_powergate_sequence_power_up() powers up partition and also enables clock & reset. However, if a controller like PCIe have multiple clocks & resets and they need to be enabled in a sequence, driver must use standalone function tegra_powergate_power_on() to power up partition. Export tegra_powergate_power_on() to allow Tegra controller drivers to unpower gate partition independent to clock & reset. Signed-off-by: Manikanta Maddireddy <mmaddireddy@nvidia.com> --- V2: No change drivers/soc/tegra/pmc.c | 1 + 1 file changed, 1 insertion(+)