diff mbox series

PCI: Remove unused attr variable in pci_dma_configure

Message ID 20181215014900.10308-1-natechancellor@gmail.com
State Not Applicable
Delegated to: Bjorn Helgaas
Headers show
Series PCI: Remove unused attr variable in pci_dma_configure | expand

Commit Message

Nathan Chancellor Dec. 15, 2018, 1:49 a.m. UTC
Clang warns:

drivers/pci/pci-driver.c:1603:21: error: unused variable 'attr'
[-Werror,-Wunused-variable]

Commit e5361ca29f2f ("ACPI / scan: Refactor _CCA enforcement") removed
attr's use and replaced it with its assigned value so it is no longer
needed.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---

The commit that causes this warning is in Christoph's dma-mapping tree
so I assume this will go there too (roll it into it if need be).

 drivers/pci/pci-driver.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Christoph Hellwig Dec. 15, 2018, 10:03 a.m. UTC | #1
Thanks, applied.

FYI, this was my editing of Robins patch that I though I had undone
again, but only half so.  Sorry.
diff mbox series

Patch

diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 1b58e058b13f..ea55444e6ead 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -1600,7 +1600,6 @@  static int pci_dma_configure(struct device *dev)
 		ret = of_dma_configure(dev, bridge->parent->of_node, true);
 	} else if (has_acpi_companion(bridge)) {
 		struct acpi_device *adev = to_acpi_device_node(bridge->fwnode);
-		enum dev_dma_attr attr = acpi_get_dma_attr(adev);
 
 		ret = acpi_dma_configure(dev, acpi_get_dma_attr(adev));
 	}