| Message ID | 20181201160711.GA21373@ycd-dell-ltp |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pcie: portdrv: Fix Unnecessary space before function pointer arguments | expand |
On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote: > Made spacing more consistent in the code for function pointer > declarations based on checkpatch.pl > > Signed-off-by: Benjamin Young <youngcdev@gmail.com> Applied to pci/misc for v4.21, thanks! I also made similar changes to include/linux/pci.h. For trivial changes like this I like to fix similar issues in all of PCI at the same time. > --- > drivers/pci/pcie/portdrv.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h > index e495f04..fbbf00b0 100644 > --- a/drivers/pci/pcie/portdrv.h > +++ b/drivers/pci/pcie/portdrv.h > @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev) > > struct pcie_port_service_driver { > const char *name; > - int (*probe) (struct pcie_device *dev); > - void (*remove) (struct pcie_device *dev); > - int (*suspend) (struct pcie_device *dev); > - int (*resume_noirq) (struct pcie_device *dev); > - int (*resume) (struct pcie_device *dev); > - int (*runtime_suspend) (struct pcie_device *dev); > - int (*runtime_resume) (struct pcie_device *dev); > + int (*probe)(struct pcie_device *dev); > + void (*remove)(struct pcie_device *dev); > + int (*suspend)(struct pcie_device *dev); > + int (*resume_noirq)(struct pcie_device *dev); > + int (*resume)(struct pcie_device *dev); > + int (*runtime_suspend)(struct pcie_device *dev); > + int (*runtime_resume)(struct pcie_device *dev); > > /* Device driver may resume normal operations */ > void (*error_resume)(struct pci_dev *dev); > > /* Link Reset Capability - AER service driver specific */ > - pci_ers_result_t (*reset_link) (struct pci_dev *dev); > + pci_ers_result_t (*reset_link)(struct pci_dev *dev); > > int port_type; /* Type of the port this driver can handle */ > u32 service; /* Port service this device represents */ > -- > 2.5.0 >
Thanks, I will do that next time :) On Thu, Dec 6, 2018 at 12:44 PM Bjorn Helgaas <helgaas@kernel.org> wrote: > > On Sat, Dec 01, 2018 at 08:07:11AM -0800, Benjamin Young wrote: > > Made spacing more consistent in the code for function pointer > > declarations based on checkpatch.pl > > > > Signed-off-by: Benjamin Young <youngcdev@gmail.com> > > Applied to pci/misc for v4.21, thanks! > > I also made similar changes to include/linux/pci.h. For trivial changes > like this I like to fix similar issues in all of PCI at the same time. > > > --- > > drivers/pci/pcie/portdrv.h | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h > > index e495f04..fbbf00b0 100644 > > --- a/drivers/pci/pcie/portdrv.h > > +++ b/drivers/pci/pcie/portdrv.h > > @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev) > > > > struct pcie_port_service_driver { > > const char *name; > > - int (*probe) (struct pcie_device *dev); > > - void (*remove) (struct pcie_device *dev); > > - int (*suspend) (struct pcie_device *dev); > > - int (*resume_noirq) (struct pcie_device *dev); > > - int (*resume) (struct pcie_device *dev); > > - int (*runtime_suspend) (struct pcie_device *dev); > > - int (*runtime_resume) (struct pcie_device *dev); > > + int (*probe)(struct pcie_device *dev); > > + void (*remove)(struct pcie_device *dev); > > + int (*suspend)(struct pcie_device *dev); > > + int (*resume_noirq)(struct pcie_device *dev); > > + int (*resume)(struct pcie_device *dev); > > + int (*runtime_suspend)(struct pcie_device *dev); > > + int (*runtime_resume)(struct pcie_device *dev); > > > > /* Device driver may resume normal operations */ > > void (*error_resume)(struct pci_dev *dev); > > > > /* Link Reset Capability - AER service driver specific */ > > - pci_ers_result_t (*reset_link) (struct pci_dev *dev); > > + pci_ers_result_t (*reset_link)(struct pci_dev *dev); > > > > int port_type; /* Type of the port this driver can handle */ > > u32 service; /* Port service this device represents */ > > -- > > 2.5.0 > >
diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index e495f04..fbbf00b0 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -71,19 +71,19 @@ static inline void *get_service_data(struct pcie_device *dev) struct pcie_port_service_driver { const char *name; - int (*probe) (struct pcie_device *dev); - void (*remove) (struct pcie_device *dev); - int (*suspend) (struct pcie_device *dev); - int (*resume_noirq) (struct pcie_device *dev); - int (*resume) (struct pcie_device *dev); - int (*runtime_suspend) (struct pcie_device *dev); - int (*runtime_resume) (struct pcie_device *dev); + int (*probe)(struct pcie_device *dev); + void (*remove)(struct pcie_device *dev); + int (*suspend)(struct pcie_device *dev); + int (*resume_noirq)(struct pcie_device *dev); + int (*resume)(struct pcie_device *dev); + int (*runtime_suspend)(struct pcie_device *dev); + int (*runtime_resume)(struct pcie_device *dev); /* Device driver may resume normal operations */ void (*error_resume)(struct pci_dev *dev); /* Link Reset Capability - AER service driver specific */ - pci_ers_result_t (*reset_link) (struct pci_dev *dev); + pci_ers_result_t (*reset_link)(struct pci_dev *dev); int port_type; /* Type of the port this driver can handle */ u32 service; /* Port service this device represents */
Made spacing more consistent in the code for function pointer declarations based on checkpatch.pl Signed-off-by: Benjamin Young <youngcdev@gmail.com> --- drivers/pci/pcie/portdrv.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)