| Message ID | 20180720150158.GA10922@embeddedor.com |
|---|---|
| State | Accepted |
| Delegated to: | Lorenzo Pieralisi |
| Headers | show |
| Series | PCI: mediatek: Fix unchecked return value | expand |
On Fri, 2018-07-20 at 10:01 -0500, Gustavo A. R. Silva wrote: > Check return value of devm_pci_remap_iospace. > > Notice that, currently, all instances of devm_pci_remap_iospace > are being checked. > > Addresses-Coverity-ID: 1471965 ("Unchecked return value") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/pci/controller/pcie-mediatek.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Hi, Gustavo, thanks for your help. Acked-by: Honghui Zhang <honghui.zhang@mediatek.com> > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c > index 861dda6..1477939 100644 > --- a/drivers/pci/controller/pcie-mediatek.c > +++ b/drivers/pci/controller/pcie-mediatek.c > @@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie) > if (err < 0) > return err; > > - devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); > + err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); > + if (err) > + return err; > > return 0; > }
On Fri, Jul 20, 2018 at 10:01:58AM -0500, Gustavo A. R. Silva wrote: > Check return value of devm_pci_remap_iospace. > > Notice that, currently, all instances of devm_pci_remap_iospace > are being checked. > > Addresses-Coverity-ID: 1471965 ("Unchecked return value") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/pci/controller/pcie-mediatek.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Applied to pci/mediatek for v4.20, thanks. Lorenzo > diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c > index 861dda6..1477939 100644 > --- a/drivers/pci/controller/pcie-mediatek.c > +++ b/drivers/pci/controller/pcie-mediatek.c > @@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie) > if (err < 0) > return err; > > - devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); > + err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); > + if (err) > + return err; > > return 0; > } > -- > 2.7.4 >
diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c index 861dda6..1477939 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -1109,7 +1109,9 @@ static int mtk_pcie_request_resources(struct mtk_pcie *pcie) if (err < 0) return err; - devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); + err = devm_pci_remap_iospace(dev, &pcie->pio, pcie->io.start); + if (err) + return err; return 0; }
Check return value of devm_pci_remap_iospace. Notice that, currently, all instances of devm_pci_remap_iospace are being checked. Addresses-Coverity-ID: 1471965 ("Unchecked return value") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/pci/controller/pcie-mediatek.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)